From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 13374 invoked by alias); 4 Jun 2014 20:53:17 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 13363 invoked by uid 89); 4 Jun 2014 20:53:16 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-3.1 required=5.0 tests=AWL,BAYES_00,RCVD_IN_DNSWL_LOW,RP_MATCHES_RCVD,SPF_PASS autolearn=ham version=3.3.2 X-HELO: mail-vc0-f174.google.com Received: from mail-vc0-f174.google.com (HELO mail-vc0-f174.google.com) (209.85.220.174) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with (AES128-SHA encrypted) ESMTPS; Wed, 04 Jun 2014 20:53:15 +0000 Received: by mail-vc0-f174.google.com with SMTP id ik5so70009vcb.33 for ; Wed, 04 Jun 2014 13:53:12 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:mime-version:in-reply-to:references:date :message-id:subject:from:to:cc:content-type; bh=D3hPsSZh8N1RfSkcXAHZ6sruhf8S3RksxFVO2xLaIZ0=; b=iP/yQ3DFkH5Zi/9AqWdn/0Xqr1CRruVLqd/frPWRQ2v9RL5rZP0MTGypXl2O47UIRE vzB+wbDdxS/Sh4GJD3CYx/Pl10hBEaqGlxd1TMTRN3nJXfm8WVqO/z46l0sp0fNgGoM8 HFdW8TLojVLvTZ9HMCu4ENGBoGABAcB0u5xVh9G5AL8iqB7aEz1cmqtAxp+PNyJGJczL blqU6j4TamYem3mDbvrshzMfzbi2wdbGgPYCqVpMaR92zeBqyyBcbhWBARUu/sQRMCVK xwSDjT98J5sOlHbm582Ky7l1DYjSxFjeHRY/Rzg/Ov11SA1III2oy96mJ3SCsrpZERK6 45yw== X-Gm-Message-State: ALoCoQkh5goyA7AevGEMlYmEGxZlOal2aORIafNT+HoQZP+EWHHWmi/zU1qvzxIXnKE36alxBh5S MIME-Version: 1.0 X-Received: by 10.52.35.234 with SMTP id l10mr4799473vdj.61.1401915192827; Wed, 04 Jun 2014 13:53:12 -0700 (PDT) Received: by 10.58.198.3 with HTTP; Wed, 4 Jun 2014 13:53:12 -0700 (PDT) In-Reply-To: <538F7A06.4040108@redhat.com> References: <538F7A06.4040108@redhat.com> Date: Wed, 04 Jun 2014 20:53:00 -0000 Message-ID: Subject: Re: [PATCH] Fix py-xmethods.c when compiled with -Werror against Python 2.4 From: Siva Chandra To: Pedro Alves Cc: gdb-patches , Doug Evans , uweigand@de.ibm.com Content-Type: text/plain; charset=UTF-8 X-IsSubscribed: yes X-SW-Source: 2014-06/txt/msg00219.txt.bz2 On Wed, Jun 4, 2014 at 12:56 PM, Pedro Alves wrote: > On 06/04/2014 07:05 PM, Siva Chandra wrote: >> Does the attached patch fix the issue pointed out by Ulrich Weigand >> here: https://sourceware.org/ml/gdb-patches/2014-06/msg00169.html >> >> ChangeLog >> 2014-06-04 Siva Chandra Reddy >> >> * python/py-xmethods.c (invoke_match_method) >> (gdbpy_get_matching_xmethod_workers, gdbpy_get_xmethod_arg_types): >> Cast the second arg to PyObject_GetAttrString and >> PyObject_GetAttrString to char *. >> > > How about we handle this in a central place, like Py_DECREF is > handled ? See python-internal.h. This breakage was marked as "nice to have it fixed" for 7.8. Considering that, do you prefer that we have a Py_DECREF like solution now, or after 7.8 branching?