From: Pedro Alves <palves@redhat.com>
To: Siva Chandra <sivachandra@google.com>
Cc: gdb-patches <gdb-patches@sourceware.org>,
Doug Evans <dje@google.com>,
uweigand@de.ibm.com
Subject: Re: [PATCH] Fix py-xmethods.c when compiled with -Werror against Python 2.4
Date: Wed, 04 Jun 2014 21:06:00 -0000 [thread overview]
Message-ID: <538F8A52.6060706@redhat.com> (raw)
In-Reply-To: <CAGyQ6gzpHfaAeJ1q_Q71Y00K9kLfbEVnb=Y=30cSLaK0RuBv1A@mail.gmail.com>
On 06/04/2014 09:53 PM, Siva Chandra wrote:
> On Wed, Jun 4, 2014 at 12:56 PM, Pedro Alves <palves@redhat.com> wrote:
>> How about we handle this in a central place, like Py_DECREF is
>> handled ? See python-internal.h.
>
> This breakage was marked as "nice to have it fixed" for 7.8.
> Considering that, do you prefer that we have a Py_DECREF like solution
> now, or after 7.8 branching?
I think such a solution would be pretty safe. I'd vote just
doing it now and not having to think about it again.
--
Pedro Alves
prev parent reply other threads:[~2014-06-04 21:06 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-06-04 18:05 Siva Chandra
2014-06-04 18:13 ` Joel Brobecker
2014-06-04 18:25 ` Siva Chandra
2014-06-04 19:24 ` Joel Brobecker
2014-06-04 19:23 ` Doug Evans
2014-06-04 19:57 ` Pedro Alves
2014-06-04 20:53 ` Siva Chandra
2014-06-04 21:06 ` Pedro Alves [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=538F8A52.6060706@redhat.com \
--to=palves@redhat.com \
--cc=dje@google.com \
--cc=gdb-patches@sourceware.org \
--cc=sivachandra@google.com \
--cc=uweigand@de.ibm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox