From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 32297 invoked by alias); 4 Jun 2014 21:06:34 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 32287 invoked by uid 89); 4 Jun 2014 21:06:33 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-2.2 required=5.0 tests=AWL,BAYES_00,RP_MATCHES_RCVD,SPF_HELO_PASS,SPF_PASS autolearn=ham version=3.3.2 X-HELO: mx1.redhat.com Received: from mx1.redhat.com (HELO mx1.redhat.com) (209.132.183.28) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Wed, 04 Jun 2014 21:06:32 +0000 Received: from int-mx09.intmail.prod.int.phx2.redhat.com (int-mx09.intmail.prod.int.phx2.redhat.com [10.5.11.22]) by mx1.redhat.com (8.14.4/8.14.4) with ESMTP id s54L6S7f001437 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Wed, 4 Jun 2014 17:06:28 -0400 Received: from [127.0.0.1] (ovpn01.gateway.prod.ext.ams2.redhat.com [10.39.146.11]) by int-mx09.intmail.prod.int.phx2.redhat.com (8.14.4/8.14.4) with ESMTP id s54L6QYw016141; Wed, 4 Jun 2014 17:06:27 -0400 Message-ID: <538F8A52.6060706@redhat.com> Date: Wed, 04 Jun 2014 21:06:00 -0000 From: Pedro Alves User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:24.0) Gecko/20100101 Thunderbird/24.5.0 MIME-Version: 1.0 To: Siva Chandra CC: gdb-patches , Doug Evans , uweigand@de.ibm.com Subject: Re: [PATCH] Fix py-xmethods.c when compiled with -Werror against Python 2.4 References: <538F7A06.4040108@redhat.com> In-Reply-To: Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-SW-Source: 2014-06/txt/msg00221.txt.bz2 On 06/04/2014 09:53 PM, Siva Chandra wrote: > On Wed, Jun 4, 2014 at 12:56 PM, Pedro Alves wrote: >> How about we handle this in a central place, like Py_DECREF is >> handled ? See python-internal.h. > > This breakage was marked as "nice to have it fixed" for 7.8. > Considering that, do you prefer that we have a Py_DECREF like solution > now, or after 7.8 branching? I think such a solution would be pretty safe. I'd vote just doing it now and not having to think about it again. -- Pedro Alves