Re: [PATCH] Fix dwarf2_string_attr for -gsplit-dwarf

["Leszek Swirski via gdb-patches" <gdb-patches@sourceware.org>]

On Tue, Aug 1, 2017 at 9:20 PM, Simon Marchi <simon.marchi@polymtl.ca> wrote:
> Thanks for the patch.  I am not very knowledgeable in that area, but I
> looked at the problem for a while and I think the change is good.  DW_STRING
> (attr) is set for attribute values of this form in read_attribute_value.
> Other functions like dwarf2_const_value_attr and dump_die_shallow read
> DW_STRING (attr) when dealing with an attribute of form
> DW_FORM_GNU_str_index as well.

Thanks, I'm not particularly knowledgeable here either, but this was pretty
much the thread that I pulled on.

> If you think this will be a one-time contribution, we can merge the patch
> for you, and there is no need for copyright assignment for a simple patch
> like that.  However, if you'd like to contribute further to GDB, we can look
> into giving you write access, so you'll be able to push patches by yourself.
> Let me know which one you prefer.

Probably a one-off for now, this was pretty much just scratching an itch.
Anything that requires copyright assignment becomes more complicated for
obvious reasons if sent from my work account.

> The ChangeLog entry for this patch will go in the gdb/ChangeLog file.

Right, this is obvious with 20/20 hindsight. Thanks.

> The ChangeLog format has the function name in parentheses

Thanks, acknowledged for next time.

> The indentation for this line should be one tab + two spaces (like the
> previous line).

Yeah, I noticed that as soon as the email sent -- I had it right at one point,
but I guess I got bitten by `set expandtab` before sending. My bad.

I'm assuming you don't need anything more from me to push?

Cheers,
Leszek