From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 77520 invoked by alias); 2 Aug 2017 10:13:09 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 76017 invoked by uid 89); 2 Aug 2017 10:13:08 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-6.4 required=5.0 tests=BAYES_00,GIT_PATCH_1,RCVD_IN_DNSWL_NONE,RCVD_IN_SORBS_SPAM,RP_MATCHES_RCVD,SPF_PASS autolearn=ham version=3.3.2 spammy= X-HELO: mail-yw0-f178.google.com Received: from mail-yw0-f178.google.com (HELO mail-yw0-f178.google.com) (209.85.161.178) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Wed, 02 Aug 2017 10:13:06 +0000 Received: by mail-yw0-f178.google.com with SMTP id l82so25947461ywc.2 for ; Wed, 02 Aug 2017 03:13:06 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:in-reply-to:references:from:date :message-id:subject:to:cc; bh=U/Pb2y+Kqt5xLb7Rx4OIpegbxCsJ/XsUVm7yUkqo4UM=; b=CY5lDpXKyCdnD3BmPl5coAmAHsX3UqhTAHcvEgqmuviODsaFlNElK52bx3vvATLXuU kbjuMVuI2osLqp5PINNoRkjJOH2lw92+Z2CW/RRBJiqVCm8Td+/33Jzt5l7zTRTGItWR zJmrGVLui5+jnyOBJYbNMM1HEhV+vKlsF3N3urA+ztqfLy3cGq1P5+yw/muxIVikYMlj iUtIZ1vih+N6wjDRDDmcmUsqYGEXLAsCQSKrJgvsbkY8W4tmeRtCDE/ivUbL8+U1zxP6 MxxH9Lm7sgYosCrE4+8dJGk3SkbTynJEEffjNVIPO/8bHfdjvz5BFR4WIN8VQVZ1YKBY 8dsQ== X-Gm-Message-State: AIVw110JrI34JKsmUJL4ViOIqXQvzRdBP1BzjkoCW68MfwDbN+wAD8e2 PxhSUWyYjuAimhwO3IvEpfchRusFVjLI X-Received: by 10.13.211.197 with SMTP id v188mr20422250ywd.59.1501668784789; Wed, 02 Aug 2017 03:13:04 -0700 (PDT) MIME-Version: 1.0 Received: by 10.13.230.200 with HTTP; Wed, 2 Aug 2017 03:12:44 -0700 (PDT) In-Reply-To: <257cba5bb5ca13e66d1e0cd01175aa37@polymtl.ca> References: <20170801092030.70676-1-leszeks@google.com> <257cba5bb5ca13e66d1e0cd01175aa37@polymtl.ca> From: "Leszek Swirski via gdb-patches" Reply-To: Leszek Swirski Date: Wed, 02 Aug 2017 10:13:00 -0000 Message-ID: Subject: Re: [PATCH] Fix dwarf2_string_attr for -gsplit-dwarf To: Simon Marchi Cc: gdb-patches@sourceware.org Content-Type: text/plain; charset="UTF-8" X-SW-Source: 2017-08/txt/msg00021.txt.bz2 On Tue, Aug 1, 2017 at 9:20 PM, Simon Marchi wrote: > Thanks for the patch. I am not very knowledgeable in that area, but I > looked at the problem for a while and I think the change is good. DW_STRING > (attr) is set for attribute values of this form in read_attribute_value. > Other functions like dwarf2_const_value_attr and dump_die_shallow read > DW_STRING (attr) when dealing with an attribute of form > DW_FORM_GNU_str_index as well. Thanks, I'm not particularly knowledgeable here either, but this was pretty much the thread that I pulled on. > If you think this will be a one-time contribution, we can merge the patch > for you, and there is no need for copyright assignment for a simple patch > like that. However, if you'd like to contribute further to GDB, we can look > into giving you write access, so you'll be able to push patches by yourself. > Let me know which one you prefer. Probably a one-off for now, this was pretty much just scratching an itch. Anything that requires copyright assignment becomes more complicated for obvious reasons if sent from my work account. > The ChangeLog entry for this patch will go in the gdb/ChangeLog file. Right, this is obvious with 20/20 hindsight. Thanks. > The ChangeLog format has the function name in parentheses Thanks, acknowledged for next time. > The indentation for this line should be one tab + two spaces (like the > previous line). Yeah, I noticed that as soon as the email sent -- I had it right at one point, but I guess I got bitten by `set expandtab` before sending. My bad. I'm assuming you don't need anything more from me to push? Cheers, Leszek