Mirror of the gdb-patches mailing list
 help / color / mirror / Atom feed
From: Simon Marchi <simon.marchi@polymtl.ca>
To: Leszek Swirski <leszeks@google.com>
Cc: gdb-patches@sourceware.org
Subject: Re: [PATCH] Fix dwarf2_string_attr for -gsplit-dwarf
Date: Wed, 02 Aug 2017 10:56:00 -0000	[thread overview]
Message-ID: <1d6cd6f279a39b0dba941e995c571cab@polymtl.ca> (raw)
In-Reply-To: <CAGRskv9vDTC6mQ+Has0zripem9x0KFWRn96OYtDijFgn6=tjWQ@mail.gmail.com>

On 2017-08-02 12:12, Leszek Swirski via gdb-patches wrote:
>> If you think this will be a one-time contribution, we can merge the 
>> patch
>> for you, and there is no need for copyright assignment for a simple 
>> patch
>> like that.  However, if you'd like to contribute further to GDB, we 
>> can look
>> into giving you write access, so you'll be able to push patches by 
>> yourself.
>> Let me know which one you prefer.
> 
> Probably a one-off for now, this was pretty much just scratching an 
> itch.
> Anything that requires copyright assignment becomes more complicated 
> for
> obvious reasons if sent from my work account.

Ok.

>> The indentation for this line should be one tab + two spaces (like the
>> previous line).
> 
> Yeah, I noticed that as soon as the email sent -- I had it right at one 
> point,
> but I guess I got bitten by `set expandtab` before sending. My bad.
> 
> I'm assuming you don't need anything more from me to push?

No, it should be fine.  I'll just leave this patch up for review for a 
few days in case somebody else wants to comment, and will push after 
that.

Thanks,

Simon


  reply	other threads:[~2017-08-02 10:56 UTC|newest]

Thread overview: 12+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-08-01  9:20 Leszek Swirski via gdb-patches
2017-08-01 20:21 ` Simon Marchi
2017-08-02 10:13   ` Leszek Swirski via gdb-patches
2017-08-02 10:56     ` Simon Marchi [this message]
2017-08-07 14:47       ` Simon Marchi
2017-08-09 13:31     ` Pedro Alves
2017-10-25  9:24 Leszek Swirski via gdb-patches
2017-10-25 14:53 ` Yao Qi
2017-10-25 15:25 ` Simon Marchi
2017-10-25 15:28   ` Leszek Swirski via gdb-patches
2017-10-26 23:44     ` Simon Marchi
2017-10-27  9:19       ` Leszek Swirski via gdb-patches

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1d6cd6f279a39b0dba941e995c571cab@polymtl.ca \
    --to=simon.marchi@polymtl.ca \
    --cc=gdb-patches@sourceware.org \
    --cc=leszeks@google.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox