Mirror of the gdb-patches mailing list
 help / color / mirror / Atom feed
From: "Leszek Swirski via gdb-patches" <gdb-patches@sourceware.org>
To: gdb-patches@sourceware.org
Cc: Leszek Swirski <leszeks@google.com>
Subject: [PATCH] Fix dwarf2_string_attr for -gsplit-dwarf
Date: Tue, 01 Aug 2017 09:20:00 -0000	[thread overview]
Message-ID: <20170801092030.70676-1-leszeks@google.com> (raw)

The dwarf2_string_attr did not allow DW_FORM_GNU_str_index as a form for
string types. This manifested as null strings in the namespace_name
lookup (replaced with "(anonymous namespace)") when debugging
Fission-compiled code.

gdb/doc/ChangeLog:

	* dwarf2read.c: Fix dwarf2_string_attr to allow
	DW_FORM_GNU_str_index
---
 gdb/dwarf2read.c | 3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)

diff --git a/gdb/dwarf2read.c b/gdb/dwarf2read.c
index 2c2ecda7fc..f5bed09116 100644
--- a/gdb/dwarf2read.c
+++ b/gdb/dwarf2read.c
@@ -17623,7 +17623,8 @@ dwarf2_string_attr (struct die_info *die, unsigned int name, struct dwarf2_cu *c
   if (attr != NULL)
     {
       if (attr->form == DW_FORM_strp || attr->form == DW_FORM_line_strp
-	  || attr->form == DW_FORM_string || attr->form == DW_FORM_GNU_strp_alt)
+	  || attr->form == DW_FORM_string || DW_FORM_GNU_str_index
+          || attr->form == DW_FORM_GNU_strp_alt)
 	str = DW_STRING (attr);
       else
         complaint (&symfile_complaints,
-- 
2.14.0.rc0.400.g1c36432dff-goog


             reply	other threads:[~2017-08-01  9:20 UTC|newest]

Thread overview: 12+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-08-01  9:20 Leszek Swirski via gdb-patches [this message]
2017-08-01 20:21 ` Simon Marchi
2017-08-02 10:13   ` Leszek Swirski via gdb-patches
2017-08-02 10:56     ` Simon Marchi
2017-08-07 14:47       ` Simon Marchi
2017-08-09 13:31     ` Pedro Alves
2017-10-25  9:24 Leszek Swirski via gdb-patches
2017-10-25 14:53 ` Yao Qi
2017-10-25 15:25 ` Simon Marchi
2017-10-25 15:28   ` Leszek Swirski via gdb-patches
2017-10-26 23:44     ` Simon Marchi
2017-10-27  9:19       ` Leszek Swirski via gdb-patches

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20170801092030.70676-1-leszeks@google.com \
    --to=gdb-patches@sourceware.org \
    --cc=leszeks@google.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox