From: "Leszek Swirski via gdb-patches" <gdb-patches@sourceware.org>
To: Pedro Alves <palves@redhat.com>
Cc: Leszek Swirski via gdb-patches <gdb-patches@sourceware.org>
Subject: Re: [PATCH] [amd64] Fix AMD64 return value ABI in expression evaluation
Date: Thu, 14 Feb 2019 15:07:00 -0000 [thread overview]
Message-ID: <CAGRskv-i=fnLhSF8bYrBaUJiARK8+ARhjn=soPSxfv6avyMVVA@mail.gmail.com> (raw)
In-Reply-To: <45c95dd6-7ea2-5428-c520-974452c6db89@redhat.com>
On Thu, Feb 14, 2019 at 3:28 PM Pedro Alves <palves@redhat.com> wrote:
> I wonder whether this fixes PR gdb/24104,
> <https://sourceware.org/bugzilla/show_bug.cgi?id=24104>.
Doesn't look like it, nor would I expect it too -- all those functions
return ints after all. Anything after the first stack frame won't
matter.
> Generally looks good. Some minor comments below.
Thanks, new patch incoming. Apologies for the style violation churn,
I'm not that used to the GNU style guide.
next prev parent reply other threads:[~2019-02-14 15:07 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-02-14 13:35 Leszek Swirski via gdb-patches
2019-02-14 14:28 ` Pedro Alves
2019-02-14 15:07 ` Leszek Swirski via gdb-patches [this message]
2019-02-14 15:16 ` [PATCH v2] " Leszek Swirski via gdb-patches
2019-02-14 15:18 ` [PATCH v3] " Leszek Swirski via gdb-patches
2019-02-14 15:26 ` Pedro Alves
2019-04-13 16:24 ` Leszek Swirski via gdb-patches
2019-04-16 16:39 ` Tom Tromey
2019-04-16 18:28 ` Tom Tromey
2019-04-24 18:03 ` Tom Tromey
2019-04-17 22:30 ` Tom de Vries
2019-04-18 17:54 ` Tom Tromey
2019-04-24 16:26 ` Regressions on gdb.base/call-{ar,rt}-st.exp on x86_64 native (was: Re: [PATCH v3] [amd64] Fix AMD64 return value ABI in expression evaluation) Sergio Durigan Junior
2019-04-24 17:51 ` Regressions on gdb.base/call-{ar,rt}-st.exp on x86_64 native Tom Tromey
2019-04-24 18:02 ` Sergio Durigan Junior
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CAGRskv-i=fnLhSF8bYrBaUJiARK8+ARhjn=soPSxfv6avyMVVA@mail.gmail.com' \
--to=gdb-patches@sourceware.org \
--cc=leszeks@google.com \
--cc=palves@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox