From: Tom Tromey <tom@tromey.com>
To: Tom Tromey <tromey@adacore.com>
Cc: "Leszek Swirski via gdb-patches" <gdb-patches@sourceware.org>,
Leszek Swirski <leszeks@google.com>,
palves@redhat.com
Subject: Re: [PATCH v3] [amd64] Fix AMD64 return value ABI in expression evaluation
Date: Wed, 24 Apr 2019 18:03:00 -0000 [thread overview]
Message-ID: <874l6ngu0t.fsf@tromey.com> (raw)
In-Reply-To: <87o955u7nl.fsf@tromey.com> (Tom Tromey's message of "Tue, 16 Apr 2019 12:28:14 -0600")
>>>>> "Tom" == Tom Tromey <tromey@adacore.com> writes:
Tom> The appended fixes the test case that's included, but I'm not really
Tom> sure it's correct, since I am not sure that the test for
Tom> "bit-field-ness" is correct here.
Tom> Let me know what you think.
I'm checking this in now.
It seems to me that since this fixes the regression and also does not
regress the other new tests that it must be at least an improvement.
Tom
next prev parent reply other threads:[~2019-04-24 18:03 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-02-14 13:35 [PATCH] " Leszek Swirski via gdb-patches
2019-02-14 14:28 ` Pedro Alves
2019-02-14 15:07 ` Leszek Swirski via gdb-patches
2019-02-14 15:16 ` [PATCH v2] " Leszek Swirski via gdb-patches
2019-02-14 15:18 ` [PATCH v3] " Leszek Swirski via gdb-patches
2019-02-14 15:26 ` Pedro Alves
2019-04-13 16:24 ` Leszek Swirski via gdb-patches
2019-04-16 16:39 ` Tom Tromey
2019-04-16 18:28 ` Tom Tromey
2019-04-24 18:03 ` Tom Tromey [this message]
2019-04-17 22:30 ` Tom de Vries
2019-04-18 17:54 ` Tom Tromey
2019-04-24 16:26 ` Regressions on gdb.base/call-{ar,rt}-st.exp on x86_64 native (was: Re: [PATCH v3] [amd64] Fix AMD64 return value ABI in expression evaluation) Sergio Durigan Junior
2019-04-24 17:51 ` Regressions on gdb.base/call-{ar,rt}-st.exp on x86_64 native Tom Tromey
2019-04-24 18:02 ` Sergio Durigan Junior
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=874l6ngu0t.fsf@tromey.com \
--to=tom@tromey.com \
--cc=gdb-patches@sourceware.org \
--cc=leszeks@google.com \
--cc=palves@redhat.com \
--cc=tromey@adacore.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox