From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 54081 invoked by alias); 24 Apr 2019 18:03:50 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 54073 invoked by uid 89); 24 Apr 2019 18:03:50 -0000 Authentication-Results: sourceware.org; auth=none X-Spam-SWARE-Status: No, score=-8.3 required=5.0 tests=AWL,BAYES_00,RCVD_IN_DNSWL_NONE,SPF_HELO_PASS autolearn=ham version=3.3.1 spammy= X-HELO: gateway23.websitewelcome.com Received: from gateway23.websitewelcome.com (HELO gateway23.websitewelcome.com) (192.185.47.80) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Wed, 24 Apr 2019 18:03:48 +0000 Received: from cm16.websitewelcome.com (cm16.websitewelcome.com [100.42.49.19]) by gateway23.websitewelcome.com (Postfix) with ESMTP id 6424A1A312 for ; Wed, 24 Apr 2019 13:03:47 -0500 (CDT) Received: from box5379.bluehost.com ([162.241.216.53]) by cmsmtp with SMTP id JMFHhhzBp4FKpJMFHh9qOX; Wed, 24 Apr 2019 13:03:47 -0500 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=tromey.com; s=default; h=Content-Type:MIME-Version:Message-ID:In-Reply-To:Date: References:Subject:Cc:To:From:Sender:Reply-To:Content-Transfer-Encoding: Content-ID:Content-Description:Resent-Date:Resent-From:Resent-Sender: Resent-To:Resent-Cc:Resent-Message-ID:List-Id:List-Help:List-Unsubscribe: List-Subscribe:List-Post:List-Owner:List-Archive; bh=GnLQqjuyPcmxu7NSkW4XQtFZDXFr/6V7SHCRe+OTZwE=; b=HmlBgddMFPBXAmJP7aoV5qjwJg mLNKt+DYzA6zKRXvl5CVfJv8olDbIbWI3jmsHlaVKDrb50ikFa6hBrZdzNrFcLM8L+isn9ImEnghK 2SDsYc48Wk+rG/Co4DVKfIIpN; Received: from 97-122-168-123.hlrn.qwest.net ([97.122.168.123]:53838 helo=murgatroyd) by box5379.bluehost.com with esmtpsa (TLSv1.2:ECDHE-RSA-AES256-GCM-SHA384:256) (Exim 4.91) (envelope-from ) id 1hJMFH-003GEY-5W; Wed, 24 Apr 2019 13:03:47 -0500 From: Tom Tromey To: Tom Tromey Cc: "Leszek Swirski via gdb-patches" , Leszek Swirski , palves@redhat.com Subject: Re: [PATCH v3] [amd64] Fix AMD64 return value ABI in expression evaluation References: <20190214151602.147300-1-leszeks@google.com> <20190214151810.149322-1-leszeks@google.com> <87v9zducov.fsf@tromey.com> <87o955u7nl.fsf@tromey.com> Date: Wed, 24 Apr 2019 18:03:00 -0000 In-Reply-To: <87o955u7nl.fsf@tromey.com> (Tom Tromey's message of "Tue, 16 Apr 2019 12:28:14 -0600") Message-ID: <874l6ngu0t.fsf@tromey.com> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/26.1 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-SW-Source: 2019-04/txt/msg00486.txt.bz2 >>>>> "Tom" == Tom Tromey writes: Tom> The appended fixes the test case that's included, but I'm not really Tom> sure it's correct, since I am not sure that the test for Tom> "bit-field-ness" is correct here. Tom> Let me know what you think. I'm checking this in now. It seems to me that since this fixes the regression and also does not regress the other new tests that it must be at least an improvement. Tom