From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <gdb-patches-return-153958-listarch-gdb-patches=sources.redhat.com@sourceware.org>
Received: (qmail 43120 invoked by alias); 14 Feb 2019 15:07:59 -0000
Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm
Precedence: bulk
List-Id: <gdb-patches.sourceware.org>
List-Subscribe: <mailto:gdb-patches-subscribe@sourceware.org>
List-Archive: <http://sourceware.org/ml/gdb-patches/>
List-Post: <mailto:gdb-patches@sourceware.org>
List-Help: <mailto:gdb-patches-help@sourceware.org>, <http://sourceware.org/ml/#faqs>
Sender: gdb-patches-owner@sourceware.org
Received: (qmail 43106 invoked by uid 89); 14 Feb 2019 15:07:58 -0000
Authentication-Results: sourceware.org; auth=none
X-Spam-SWARE-Status: No, score=-9.9 required=5.0 tests=BAYES_00,ENV_AND_HDR_SPF_MATCH,RCVD_IN_DNSWL_NONE,SPF_PASS,USER_IN_DEF_SPF_WL autolearn=ham version=3.3.2 spammy=Hx-languages-length:555
X-HELO: mail-yb1-f173.google.com
Received: from mail-yb1-f173.google.com (HELO mail-yb1-f173.google.com) (209.85.219.173) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Thu, 14 Feb 2019 15:07:57 +0000
Received: by mail-yb1-f173.google.com with SMTP id s76so2485154ybs.10        for <gdb-patches@sourceware.org>; Thu, 14 Feb 2019 07:07:56 -0800 (PST)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;        d=google.com; s=20161025;        h=mime-version:references:in-reply-to:from:date:message-id:subject:to         :cc;        bh=M6TegBO98f9OBuWFj0GZ6z6lsYE3jaDSv31b9W4FpKw=;        b=WOmXgDIQKo8E/iCMt08i0sv7BJp8eXmJc6M8dM1U9i1l3cckzyzOocCQOkyu4sQB2L         6tizwQxjw6qjIgfVoUM80tUvE8+XPHpDLCKxJgnq8WWRUgaxtMOUbaMqZzZ1qXalSw5B         qv/xPsbr8ZlB6bwwR2Kog7sdjTFFT1gG74ef0oshdqqx3TfXbXH8GwourPZADwtq0WPM         aiFDNlORduvfQkij/livb5KuRSqNcEnRoz5ZggSOI114b6rH50zfwPiLVm2+eeUSqlE6         GYeRHIeyOAUo6eMejrRPGT0+uP2cH1suzoSB1NMzCB9FWUdHKkxx4ko/q+LLRVuga1BZ         dT6w==
MIME-Version: 1.0
References: <20190214133507.38697-1-leszeks@google.com> <45c95dd6-7ea2-5428-c520-974452c6db89@redhat.com>
In-Reply-To: <45c95dd6-7ea2-5428-c520-974452c6db89@redhat.com>
From: "Leszek Swirski via gdb-patches" <gdb-patches@sourceware.org>
Reply-To: Leszek Swirski <leszeks@google.com>
Date: Thu, 14 Feb 2019 15:07:00 -0000
Message-ID: <CAGRskv-i=fnLhSF8bYrBaUJiARK8+ARhjn=soPSxfv6avyMVVA@mail.gmail.com>
Subject: Re: [PATCH] [amd64] Fix AMD64 return value ABI in expression evaluation
To: Pedro Alves <palves@redhat.com>
Cc: Leszek Swirski via gdb-patches <gdb-patches@sourceware.org>
Content-Type: text/plain; charset="UTF-8"
X-SW-Source: 2019-02/txt/msg00225.txt.bz2

On Thu, Feb 14, 2019 at 3:28 PM Pedro Alves <palves@redhat.com> wrote:
> I wonder whether this fixes PR gdb/24104,
> <https://sourceware.org/bugzilla/show_bug.cgi?id=24104>.
Doesn't look like it, nor would I expect it too -- all those functions
return ints after all. Anything after the first stack frame won't
matter.

> Generally looks good.  Some minor comments below.
Thanks, new patch incoming. Apologies for the style violation churn,
I'm not that used to the GNU style guide.