From: "Leszek Swirski via gdb-patches" <gdb-patches@sourceware.org>
To: Tom Tromey <tom@tromey.com>
Cc: Leszek Swirski via gdb-patches <gdb-patches@sourceware.org>
Subject: Re: [PATCH v2] Do not classify C struct members as a filename
Date: Thu, 25 Jan 2018 16:39:00 -0000 [thread overview]
Message-ID: <CAGRskv-6-Bp3XoMhziROC04md4xOe0mny4cBu5Lo=S0=3pjWxA@mail.gmail.com> (raw)
In-Reply-To: <87zi52gc8u.fsf@tromey.com>
> This change makes sense (and thanks for updating that comment as well),
> but I wonder whether this changes the behavior in some case. Elsewhere
> in lex_one_token there is a check of saw_structop:
>
> else if (saw_structop)
> return COMPLETE;
>
> Previously this return could only be taken if parse_completion was set,
> but now I think it could be taken in other situations.
>
> So, I suspect "parse_completion &&" should be stuck in there.
Nice catch, thanks! I looked at the other users of saw_structop and
last_was_structop, and it looks like this is the only location that
needs an update. PTAL at v4.
prev parent reply other threads:[~2018-01-25 16:39 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-01-24 16:51 Leszek Swirski via gdb-patches
2018-01-25 2:39 ` Simon Marchi
2018-01-25 10:04 ` Leszek Swirski via gdb-patches
2018-01-25 14:52 ` Simon Marchi
2018-01-25 15:09 ` [PATCH v3] " Leszek Swirski via gdb-patches
2018-01-25 16:00 ` [PATCH v2] " Tom Tromey
2018-01-25 16:20 ` [PATCH v4] " Leszek Swirski via gdb-patches
2018-02-02 3:35 ` Simon Marchi
2018-01-25 16:39 ` Leszek Swirski via gdb-patches [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CAGRskv-6-Bp3XoMhziROC04md4xOe0mny4cBu5Lo=S0=3pjWxA@mail.gmail.com' \
--to=gdb-patches@sourceware.org \
--cc=leszeks@google.com \
--cc=tom@tromey.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox