From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <gdb-patches-return-145062-listarch-gdb-patches=sources.redhat.com@sourceware.org>
Received: (qmail 9979 invoked by alias); 25 Jan 2018 16:39:19 -0000
Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm
Precedence: bulk
List-Id: <gdb-patches.sourceware.org>
List-Subscribe: <mailto:gdb-patches-subscribe@sourceware.org>
List-Archive: <http://sourceware.org/ml/gdb-patches/>
List-Post: <mailto:gdb-patches@sourceware.org>
List-Help: <mailto:gdb-patches-help@sourceware.org>, <http://sourceware.org/ml/#faqs>
Sender: gdb-patches-owner@sourceware.org
Received: (qmail 9867 invoked by uid 89); 25 Jan 2018 16:39:19 -0000
Authentication-Results: sourceware.org; auth=none
X-Virus-Found: No
X-Spam-SWARE-Status: No, score=-2.0 required=5.0 tests=AWL,BAYES_00,RCVD_IN_DNSWL_NONE,SPF_PASS,T_RP_MATCHES_RCVD autolearn=ham version=3.3.2 spammy=
X-HELO: mail-yw0-f171.google.com
Received: from mail-yw0-f171.google.com (HELO mail-yw0-f171.google.com) (209.85.161.171) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Thu, 25 Jan 2018 16:39:17 +0000
Received: by mail-yw0-f171.google.com with SMTP id u17so3139273ywg.9        for <gdb-patches@sourceware.org>; Thu, 25 Jan 2018 08:39:17 -0800 (PST)
X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;        d=1e100.net; s=20161025;        h=x-gm-message-state:mime-version:in-reply-to:references:from:date         :message-id:subject:to:cc;        bh=GXNpEXftTDf8PEMsnhwLRluB8HbT+mhGJvvx+2aPZwQ=;        b=XcQE4d6UkSzeelxBAzowQPyPKGwYuOgzJgnKXZeBF9+vm4FZXlOJWY6ohNqdnQ1SpP         W3s6cpBKgtRQEPTck+cYo/SqyZRulKRAQQd7TwJAi+YUXBxV56ai5/RdKZ0P90UzrzqN         fxqX/pQlSGD9eVewzXXp+FyG9SwA3h05o+zvOyrTyy3NMsNsOyTVtCO25MVaPILEWgts         MZz5uHJX6i8j3wa5O0hK/NKDJq8aStIrgPTOfNvCDyFHhI5n5AyiB1U0OPeSNX8vdier         xB8TOuiJl6z+KjiMYyJ02MMRseoWPPc6goZvTIeA9B+H5EfgDQEDgZvAOpprwbhj6B/3         2zfg==
X-Gm-Message-State: AKwxytf0hU8KHmaie8LGb2drwoCwFZfD0JoSpyYrB9JO1XGHWUY1/6Zg	SYOsay9isqScTAlqomICdxKo+5/Xinm/wNNU7uISlQ==
X-Google-Smtp-Source: AH8x227p7/0O6RtomzpRWCgF/aOu7K/oTLe6O5mMViKalv5DCffBkHEI42PP+sdwZSABt4Jxz7mq+/ezT+YaiJW0jS4=
X-Received: by 10.129.52.2 with SMTP id b2mr9012109ywa.264.1516898355851; Thu, 25 Jan 2018 08:39:15 -0800 (PST)
MIME-Version: 1.0
Received: by 10.37.133.141 with HTTP; Thu, 25 Jan 2018 08:38:55 -0800 (PST)
In-Reply-To: <87zi52gc8u.fsf@tromey.com>
References: <20180124165107.186980-1-leszeks@google.com> <87zi52gc8u.fsf@tromey.com>
From: "Leszek Swirski via gdb-patches" <gdb-patches@sourceware.org>
Reply-To: Leszek Swirski <leszeks@google.com>
Date: Thu, 25 Jan 2018 16:39:00 -0000
Message-ID: <CAGRskv-6-Bp3XoMhziROC04md4xOe0mny4cBu5Lo=S0=3pjWxA@mail.gmail.com>
Subject: Re: [PATCH v2] Do not classify C struct members as a filename
To: Tom Tromey <tom@tromey.com>
Cc: Leszek Swirski via gdb-patches <gdb-patches@sourceware.org>
Content-Type: text/plain; charset="UTF-8"
X-SW-Source: 2018-01/txt/msg00536.txt.bz2

> This change makes sense (and thanks for updating that comment as well),
> but I wonder whether this changes the behavior in some case.  Elsewhere
> in lex_one_token there is a check of saw_structop:
>
>       else if (saw_structop)
>         return COMPLETE;
>
> Previously this return could only be taken if parse_completion was set,
> but now I think it could be taken in other situations.
>
> So, I suspect "parse_completion &&" should be stuck in there.

Nice catch, thanks! I looked at the other users of saw_structop and
last_was_structop, and it looks like this is the only location that
needs an update. PTAL at v4.