From: Simon Marchi <simon.marchi@polymtl.ca>
To: Leszek Swirski <leszeks@google.com>
Cc: gdb-patches@sourceware.org
Subject: Re: [PATCH v2] Do not classify C struct members as a filename
Date: Thu, 25 Jan 2018 14:52:00 -0000 [thread overview]
Message-ID: <7e304815dd4d3f8e8ab89fa718854ccc@polymtl.ca> (raw)
In-Reply-To: <CAGRskv_cTmN0Cic8gMmHW6A54tA3Kpm+8JGLxS8r8Jwv6GWMbg@mail.gmail.com>
On 2018-01-25 05:03, Leszek Swirski via gdb-patches wrote:
> Hi Simon, thanks for taking a look.
>
> Sure, I can update the tests (I'll add some tests for checking
> "c.includefile" while I'm at it) and change the int to a bool. I'm not
> 100%
> sure on the procedure here, do you want me to upload a v3 as a new
> thread?
>
> - Leszek
Hi Leszek,
Yes, sending a v3 would be ideal. It's usually a new thread (as in
there is no "Re:"), but some people like to use git-send-email's
--in-reply-to option to refer to the previous version, so that the
different versions thread nicely in email clients. It's up to you.
Simon
next prev parent reply other threads:[~2018-01-25 14:52 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-01-24 16:51 Leszek Swirski via gdb-patches
2018-01-25 2:39 ` Simon Marchi
2018-01-25 10:04 ` Leszek Swirski via gdb-patches
2018-01-25 14:52 ` Simon Marchi [this message]
2018-01-25 15:09 ` [PATCH v3] " Leszek Swirski via gdb-patches
2018-01-25 16:00 ` [PATCH v2] " Tom Tromey
2018-01-25 16:20 ` [PATCH v4] " Leszek Swirski via gdb-patches
2018-02-02 3:35 ` Simon Marchi
2018-01-25 16:39 ` [PATCH v2] " Leszek Swirski via gdb-patches
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=7e304815dd4d3f8e8ab89fa718854ccc@polymtl.ca \
--to=simon.marchi@polymtl.ca \
--cc=gdb-patches@sourceware.org \
--cc=leszeks@google.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox