From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 71991 invoked by alias); 25 Jan 2018 14:52:20 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 71979 invoked by uid 89); 25 Jan 2018 14:52:20 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-2.5 required=5.0 tests=AWL,BAYES_00,SPF_HELO_PASS,SPF_PASS,T_RP_MATCHES_RCVD autolearn=ham version=3.3.2 spammy= X-HELO: smtp.polymtl.ca Received: from smtp.polymtl.ca (HELO smtp.polymtl.ca) (132.207.4.11) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Thu, 25 Jan 2018 14:52:19 +0000 Received: from simark.ca (simark.ca [158.69.221.121]) (authenticated bits=0) by smtp.polymtl.ca (8.14.7/8.14.7) with ESMTP id w0PEqC6M020495 (version=TLSv1/SSLv3 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT) for ; Thu, 25 Jan 2018 09:52:17 -0500 Received: by simark.ca (Postfix, from userid 112) id A513C1E5B6; Thu, 25 Jan 2018 09:52:12 -0500 (EST) Received: from simark.ca (localhost [127.0.0.1]) by simark.ca (Postfix) with ESMTP id 30D221E512; Thu, 25 Jan 2018 09:52:12 -0500 (EST) MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII; format=flowed Content-Transfer-Encoding: 7bit Date: Thu, 25 Jan 2018 14:52:00 -0000 From: Simon Marchi To: Leszek Swirski Cc: gdb-patches@sourceware.org Subject: Re: [PATCH v2] Do not classify C struct members as a filename In-Reply-To: References: <20180124165107.186980-1-leszeks@google.com> <6c3f1fc7d56feaaa00ade76f51f7421f@polymtl.ca> Message-ID: <7e304815dd4d3f8e8ab89fa718854ccc@polymtl.ca> X-Sender: simon.marchi@polymtl.ca User-Agent: Roundcube Webmail/1.3.2 X-Poly-FromMTA: (simark.ca [158.69.221.121]) at Thu, 25 Jan 2018 14:52:12 +0000 X-IsSubscribed: yes X-SW-Source: 2018-01/txt/msg00528.txt.bz2 On 2018-01-25 05:03, Leszek Swirski via gdb-patches wrote: > Hi Simon, thanks for taking a look. > > Sure, I can update the tests (I'll add some tests for checking > "c.includefile" while I'm at it) and change the int to a bool. I'm not > 100% > sure on the procedure here, do you want me to upload a v3 as a new > thread? > > - Leszek Hi Leszek, Yes, sending a v3 would be ideal. It's usually a new thread (as in there is no "Re:"), but some people like to use git-send-email's --in-reply-to option to refer to the previous version, so that the different versions thread nicely in email clients. It's up to you. Simon