[FYI] Adding myself to MAINTAINERS(Commit After Approval)

[FYI] Adding myself to MAINTAINERS(Commit After Approval)

[David Blaikie]

[-- Attachment #1: Type: text/plain, Size: 17 bytes --]

(patch attached)

[-- Attachment #2: maint.diff --]
[-- Type: application/octet-stream, Size: 543 bytes --]

? patch.txt
Index: ChangeLog
===================================================================
RCS file: /cvs/src/src/gdb/ChangeLog,v
retrieving revision 1.15036
diff -r1.15036 ChangeLog
0a1,3
> 2012-12-12  David Blaikie  <dblaikie@gmail.com>
> 
>         * MAINTAINERS (Write After Approval): Add "David Blaikie".
Index: MAINTAINERS
===================================================================
RCS file: /cvs/src/src/gdb/MAINTAINERS,v
retrieving revision 1.497
diff -r1.497 MAINTAINERS
469a470
> David Blaikie					dblaikie@gmail.com

Re: [FYI] Adding myself to MAINTAINERS(Commit After Approval)

[Sergio Durigan Junior]

On Friday, January 18 2013, David Blaikie wrote:

> RCS file: /cvs/src/src/gdb/ChangeLog,v
> retrieving revision 1.15036
> diff -r1.15036 ChangeLog
> 0a1,3
>> 2012-12-12  David Blaikie  <dblaikie@gmail.com>
>> 
>>         * MAINTAINERS (Write After Approval): Add "David Blaikie".

Hi David,

The date is wrong, and the lines in the ChangeLog file shall be indented
using TABs, not spaces.  You should also add a blank line between your
entry and the last one.

Please fix those errors (there's no need to create a new ChangeLog entry
for this fix).

Thanks,

-- 
Sergio

Re: [FYI] Adding myself to MAINTAINERS(Commit After Approval)

[David Blaikie]

On Fri, Jan 18, 2013 at 1:16 PM, Sergio Durigan Junior
<sergiodj@redhat.com> wrote:
> On Friday, January 18 2013, David Blaikie wrote:
>
>> RCS file: /cvs/src/src/gdb/ChangeLog,v
>> retrieving revision 1.15036
>> diff -r1.15036 ChangeLog
>> 0a1,3
>>> 2012-12-12  David Blaikie  <dblaikie@gmail.com>
>>>
>>>         * MAINTAINERS (Write After Approval): Add "David Blaikie".
>
> Hi David,
>
> The date is wrong, and the lines in the ChangeLog file shall be indented
> using TABs, not spaces.  You should also add a blank line between your
> entry and the last one.

Sorry - amazing how many mistakes I managed to pack into such a small
change. (little rushed since I realized I'd actually committed a my
label.c patch before updating MAINTAINERS)

> Please fix those errors (there's no need to create a new ChangeLog entry
> for this fix).

Committed in 1.15038 of gdb/ChangeLog. Thanks for the review/catches.

- David

Re: [FYI] Adding myself to MAINTAINERS(Commit After Approval)

[Sergio Durigan Junior]

On Friday, January 18 2013, David Blaikie wrote:

> Sorry - amazing how many mistakes I managed to pack into such a small
> change. (little rushed since I realized I'd actually committed a my
> label.c patch before updating MAINTAINERS)

No problem :-).

>> Please fix those errors (there's no need to create a new ChangeLog entry
>> for this fix).
>
> Committed in 1.15038 of gdb/ChangeLog. Thanks for the review/catches.

Thanks,

-- 
Sergio