From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <gdb-patches-return-97828-listarch-gdb-patches=sources.redhat.com@sourceware.org>
Received: (qmail 32106 invoked by alias); 18 Jan 2013 21:44:13 -0000
Received: (qmail 32049 invoked by uid 22791); 18 Jan 2013 21:44:11 -0000
X-SWARE-Spam-Status: No, hits=-5.0 required=5.0	tests=AWL,BAYES_00,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,FREEMAIL_FROM,KHOP_RCVD_TRUST,KHOP_THREADED,RCVD_IN_DNSWL_LOW,RCVD_IN_HOSTKARMA_YE
X-Spam-Check-By: sourceware.org
Received: from mail-vb0-f46.google.com (HELO mail-vb0-f46.google.com) (209.85.212.46)    by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Fri, 18 Jan 2013 21:44:06 +0000
Received: by mail-vb0-f46.google.com with SMTP id b13so4054031vby.5        for <gdb-patches@sourceware.org>; Fri, 18 Jan 2013 13:44:06 -0800 (PST)
MIME-Version: 1.0
X-Received: by 10.220.205.134 with SMTP id fq6mr11301275vcb.24.1358545445856; Fri, 18 Jan 2013 13:44:05 -0800 (PST)
Received: by 10.220.21.12 with HTTP; Fri, 18 Jan 2013 13:44:05 -0800 (PST)
In-Reply-To: <m3hameur8a.fsf@redhat.com>
References: <CAENS6EvkcsVN3psK73DaeABy-uz_rP9Bvpf-==Rba33aqDfkKA@mail.gmail.com>	<m3hameur8a.fsf@redhat.com>
Date: Fri, 18 Jan 2013 21:44:00 -0000
Message-ID: <CAENS6EtaVL=zjNZug_AH+bpQ4wRBOemdobXA1aZkWrNWC2rs8g@mail.gmail.com>
Subject: Re: [FYI] Adding myself to MAINTAINERS(Commit After Approval)
From: David Blaikie <dblaikie@gmail.com>
To: Sergio Durigan Junior <sergiodj@redhat.com>
Cc: gdb-patches@sourceware.org
Content-Type: text/plain; charset=ISO-8859-1
X-IsSubscribed: yes
Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm
Precedence: bulk
List-Id: <gdb-patches.sourceware.org>
List-Subscribe: <mailto:gdb-patches-subscribe@sourceware.org>
List-Archive: <http://sourceware.org/ml/gdb-patches/>
List-Post: <mailto:gdb-patches@sourceware.org>
List-Help: <mailto:gdb-patches-help@sourceware.org>, <http://sourceware.org/ml/#faqs>
Sender: gdb-patches-owner@sourceware.org
X-SW-Source: 2013-01/txt/msg00458.txt.bz2

On Fri, Jan 18, 2013 at 1:16 PM, Sergio Durigan Junior
<sergiodj@redhat.com> wrote:
> On Friday, January 18 2013, David Blaikie wrote:
>
>> RCS file: /cvs/src/src/gdb/ChangeLog,v
>> retrieving revision 1.15036
>> diff -r1.15036 ChangeLog
>> 0a1,3
>>> 2012-12-12  David Blaikie  <dblaikie@gmail.com>
>>>
>>>         * MAINTAINERS (Write After Approval): Add "David Blaikie".
>
> Hi David,
>
> The date is wrong, and the lines in the ChangeLog file shall be indented
> using TABs, not spaces.  You should also add a blank line between your
> entry and the last one.

Sorry - amazing how many mistakes I managed to pack into such a small
change. (little rushed since I realized I'd actually committed a my
label.c patch before updating MAINTAINERS)

> Please fix those errors (there's no need to create a new ChangeLog entry
> for this fix).

Committed in 1.15038 of gdb/ChangeLog. Thanks for the review/catches.

- David