Mirror of the gdb-patches mailing list
 help / color / mirror / Atom feed
From: Sergio Durigan Junior <sergiodj@redhat.com>
To: David Blaikie <dblaikie@gmail.com>
Cc: gdb-patches@sourceware.org
Subject: Re: [FYI] Adding myself to MAINTAINERS(Commit After Approval)
Date: Fri, 18 Jan 2013 21:16:00 -0000	[thread overview]
Message-ID: <m3hameur8a.fsf@redhat.com> (raw)
In-Reply-To: <CAENS6EvkcsVN3psK73DaeABy-uz_rP9Bvpf-==Rba33aqDfkKA@mail.gmail.com>	(David Blaikie's message of "Fri, 18 Jan 2013 11:25:33 -0800")

On Friday, January 18 2013, David Blaikie wrote:

> RCS file: /cvs/src/src/gdb/ChangeLog,v
> retrieving revision 1.15036
> diff -r1.15036 ChangeLog
> 0a1,3
>> 2012-12-12  David Blaikie  <dblaikie@gmail.com>
>> 
>>         * MAINTAINERS (Write After Approval): Add "David Blaikie".

Hi David,

The date is wrong, and the lines in the ChangeLog file shall be indented
using TABs, not spaces.  You should also add a blank line between your
entry and the last one.

Please fix those errors (there's no need to create a new ChangeLog entry
for this fix).

Thanks,

-- 
Sergio


  reply	other threads:[~2013-01-18 21:16 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2013-01-18 19:25 David Blaikie
2013-01-18 21:16 ` Sergio Durigan Junior [this message]
2013-01-18 21:44   ` David Blaikie
2013-01-19  3:24     ` Sergio Durigan Junior

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=m3hameur8a.fsf@redhat.com \
    --to=sergiodj@redhat.com \
    --cc=dblaikie@gmail.com \
    --cc=gdb-patches@sourceware.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox