Re: [patch] [gdb/testsuite] XFAIL under Clang tests using label debug info

[David Blaikie <dblaikie@gmail.com>]

Thanks!
Committed as 736b0f76188c7a4d497a5e2255b78af909393afe

On Thu, Sep 5, 2019 at 5:53 PM Doug Evans <dje@google.com> wrote:
>
> SGTM
>
> On Thu, Sep 5, 2019 at 3:12 PM David Blaikie <dblaikie@gmail.com> wrote:
>>
>> Clang now supports labels - so I'd like to essentially revert this patch.
>>
>> Is this OK?
>>
>>
>> On Thu, Apr 24, 2014 at 8:23 PM David Blaikie <dblaikie@gmail.com> wrote:
>> >
>> > On Wed, Apr 23, 2014 at 3:03 PM, Doug Evans <dje@google.com> wrote:
>> > > David Blaikie writes:
>> > >  > Clang doesn't emit debug info for labels (Clang PR14500). XFAIL a
>> > >  > bunch of GDB tests that rely on debug info for labels.
>> > >  >
>> > >  > For some reason gdb.linespec/ls-expr.exp gathered all tests into a
>> > >  > dictionary and then ran them. This made it hard to XFAIL just the
>> > >  > right tests. I refactored this to execute the tests directly, removing
>> > >  > the dictionary so I could XFAIL the right tests. Is there a reason it
>> > >  > would've been written that way? Does my patch break it in some way?
>> > >  > commit c438cb16b63292e415330f289616c4e4ecece63c
>> > >  > Author: David Blaikie <dblaikie@gmail.com>
>> > >  > Date:   Sun Apr 13 11:42:02 2014 -0700
>> > >  >
>> > >  >     XFAIL under Clang tests using labels
>> > >  >
>> > >  >     gdb/testsuite/
>> > >  >      * gdb.base/label.exp: XFAIL label related tests under Clang.
>> > >  >      * gdb.cp/cplabel.exp: Ditto.
>> > >  >      * gdb.linespec/ls-errs.exp: Refactor tests to execute directly
>> > >  >      and XFAIL under Clang those using labels.
>> > >
>> > > LGTM
>> > >
>> > >  > diff --git gdb/testsuite/ChangeLog gdb/testsuite/ChangeLog
>> > >  > index 730c116..b04b940 100644
>> > >  > --- gdb/testsuite/ChangeLog
>> > >  > +++ gdb/testsuite/ChangeLog
>> > >  > @@ -1,3 +1,9 @@
>> > >  > +2014-04-12  David Blaikie  <dblaikie@gmail.com>
>> > >  > +
>> > >  > +        * gdb.base/label.exp: XFAIL label related tests under Clang.
>> > >  > +    * gdb.cp/cplabel.exp: Ditto.
>> > >  > +    * gdb.linespec/ls-errs.exp: Refactor tests to execute directly and XFAIL under Clang those using labels.
>> > >  > +
>> > >
>> > > Nit: space vs tabs.  Just use tabs.
>> > > Plus line is longer than 80 chars.
>> >
>> > Thanks for the catches - fixed those up and committed in
>> > c2e827ad5340fcf1735df6c77cb0311e56b985ef.
>> >
>> > Also refactored some of the xfails along the lines of what Pedro
>> > suggested in the one test case that had several similar failures
>> > (gdb.base/label.exp). If/when we fix this in Clang it might be worth
>> > refactoring into a common function (though I'm personally not very
>> > vested in keeping the test suite usable with anything other than ToT
>> > Clang - perhaps others are).