From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 72383 invoked by alias); 6 Sep 2019 21:19:00 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 72375 invoked by uid 89); 6 Sep 2019 21:18:59 -0000 Authentication-Results: sourceware.org; auth=none X-Spam-SWARE-Status: No, score=-12.3 required=5.0 tests=AWL,BAYES_00,FREEMAIL_FROM,GIT_PATCH_0,GIT_PATCH_1,GIT_PATCH_2,GIT_PATCH_3,RCVD_IN_DNSWL_NONE,SPF_PASS autolearn=ham version=3.3.1 spammy=H*RU:209.85.166.66, HX-Spam-Relays-External:209.85.166.66 X-HELO: mail-io1-f66.google.com Received: from mail-io1-f66.google.com (HELO mail-io1-f66.google.com) (209.85.166.66) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Fri, 06 Sep 2019 21:18:58 +0000 Received: by mail-io1-f66.google.com with SMTP id m11so16053897ioo.0 for ; Fri, 06 Sep 2019 14:18:58 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=JURHtZnQD+9pNrrtx9x0UO53vrD9MYKay+RcwhwJj1c=; b=bFo7k7BWcHVRTBe3kGxcMKrPV5v7Z1jaUjxwbNhK5dMLBO8fRKLz4fQlUtYKGG7/Eo sB4QDbTH9FvBeCN1ohGvnJvR3eEUOcKPGc5TkJwSwXZZnVCD1+1ZiNmXcUWZXwsTkXIk 3/B9edhDqR4TxRBTqzaX3yQYGHuukqJ2Rie+acznOiCUTE2Rei4nY/7Jn6YDZJAeE9Oi mAOEUAQSKGTRcHKI2eaSQUUcABU7xHag1CKJP8BE/iApY8h6E8ai4TOFORqpBjvU1q0N dxyUA9WDBgn0uzpRoZhy0RxH4NM+rWXWKRDZyftlafoikk+xHu4nnlD22yLvevvHSA61 rVrw== MIME-Version: 1.0 References: <21336.14486.650610.274638@ruffy.mtv.corp.google.com> In-Reply-To: From: David Blaikie Date: Fri, 06 Sep 2019 21:19:00 -0000 Message-ID: Subject: Re: [patch] [gdb/testsuite] XFAIL under Clang tests using label debug info To: Doug Evans Cc: Pedro Alves , gdb-patches Content-Type: text/plain; charset="UTF-8" X-IsSubscribed: yes X-SW-Source: 2019-09/txt/msg00074.txt.bz2 Thanks! Committed as 736b0f76188c7a4d497a5e2255b78af909393afe On Thu, Sep 5, 2019 at 5:53 PM Doug Evans wrote: > > SGTM > > On Thu, Sep 5, 2019 at 3:12 PM David Blaikie wrote: >> >> Clang now supports labels - so I'd like to essentially revert this patch. >> >> Is this OK? >> >> >> On Thu, Apr 24, 2014 at 8:23 PM David Blaikie wrote: >> > >> > On Wed, Apr 23, 2014 at 3:03 PM, Doug Evans wrote: >> > > David Blaikie writes: >> > > > Clang doesn't emit debug info for labels (Clang PR14500). XFAIL a >> > > > bunch of GDB tests that rely on debug info for labels. >> > > > >> > > > For some reason gdb.linespec/ls-expr.exp gathered all tests into a >> > > > dictionary and then ran them. This made it hard to XFAIL just the >> > > > right tests. I refactored this to execute the tests directly, removing >> > > > the dictionary so I could XFAIL the right tests. Is there a reason it >> > > > would've been written that way? Does my patch break it in some way? >> > > > commit c438cb16b63292e415330f289616c4e4ecece63c >> > > > Author: David Blaikie >> > > > Date: Sun Apr 13 11:42:02 2014 -0700 >> > > > >> > > > XFAIL under Clang tests using labels >> > > > >> > > > gdb/testsuite/ >> > > > * gdb.base/label.exp: XFAIL label related tests under Clang. >> > > > * gdb.cp/cplabel.exp: Ditto. >> > > > * gdb.linespec/ls-errs.exp: Refactor tests to execute directly >> > > > and XFAIL under Clang those using labels. >> > > >> > > LGTM >> > > >> > > > diff --git gdb/testsuite/ChangeLog gdb/testsuite/ChangeLog >> > > > index 730c116..b04b940 100644 >> > > > --- gdb/testsuite/ChangeLog >> > > > +++ gdb/testsuite/ChangeLog >> > > > @@ -1,3 +1,9 @@ >> > > > +2014-04-12 David Blaikie >> > > > + >> > > > + * gdb.base/label.exp: XFAIL label related tests under Clang. >> > > > + * gdb.cp/cplabel.exp: Ditto. >> > > > + * gdb.linespec/ls-errs.exp: Refactor tests to execute directly and XFAIL under Clang those using labels. >> > > > + >> > > >> > > Nit: space vs tabs. Just use tabs. >> > > Plus line is longer than 80 chars. >> > >> > Thanks for the catches - fixed those up and committed in >> > c2e827ad5340fcf1735df6c77cb0311e56b985ef. >> > >> > Also refactored some of the xfails along the lines of what Pedro >> > suggested in the one test case that had several similar failures >> > (gdb.base/label.exp). If/when we fix this in Clang it might be worth >> > refactoring into a common function (though I'm personally not very >> > vested in keeping the test suite usable with anything other than ToT >> > Clang - perhaps others are).