Mirror of the gdb-patches mailing list
 help / color / mirror / Atom feed
From: Doug Evans <dje@google.com>
To: David Blaikie <dblaikie@gmail.com>
Cc: gdb-patches <gdb-patches@sourceware.org>
Subject: Re: [patch] [gdb/testsuite] XFAIL under Clang tests using label debug info
Date: Wed, 23 Apr 2014 22:03:00 -0000	[thread overview]
Message-ID: <21336.14486.650610.274638@ruffy.mtv.corp.google.com> (raw)
In-Reply-To: <CAENS6EtFF4hPJe3uqJBkPf4q8c0n4RvV1_jO=6mWWEp=X2HbnA@mail.gmail.com>

David Blaikie writes:
 > Clang doesn't emit debug info for labels (Clang PR14500). XFAIL a
 > bunch of GDB tests that rely on debug info for labels.
 > 
 > For some reason gdb.linespec/ls-expr.exp gathered all tests into a
 > dictionary and then ran them. This made it hard to XFAIL just the
 > right tests. I refactored this to execute the tests directly, removing
 > the dictionary so I could XFAIL the right tests. Is there a reason it
 > would've been written that way? Does my patch break it in some way?
 > commit c438cb16b63292e415330f289616c4e4ecece63c
 > Author: David Blaikie <dblaikie@gmail.com>
 > Date:   Sun Apr 13 11:42:02 2014 -0700
 > 
 >     XFAIL under Clang tests using labels
 >     
 >     gdb/testsuite/
 >     	* gdb.base/label.exp: XFAIL label related tests under Clang.
 >     	* gdb.cp/cplabel.exp: Ditto.
 >     	* gdb.linespec/ls-errs.exp: Refactor tests to execute directly
 >     	and XFAIL under Clang those using labels.

LGTM

 > diff --git gdb/testsuite/ChangeLog gdb/testsuite/ChangeLog
 > index 730c116..b04b940 100644
 > --- gdb/testsuite/ChangeLog
 > +++ gdb/testsuite/ChangeLog
 > @@ -1,3 +1,9 @@
 > +2014-04-12  David Blaikie  <dblaikie@gmail.com>
 > +
 > +        * gdb.base/label.exp: XFAIL label related tests under Clang.
 > +	* gdb.cp/cplabel.exp: Ditto.
 > +	* gdb.linespec/ls-errs.exp: Refactor tests to execute directly and XFAIL under Clang those using labels.
 > +

Nit: space vs tabs.  Just use tabs.
Plus line is longer than 80 chars.


  reply	other threads:[~2014-04-23 22:03 UTC|newest]

Thread overview: 11+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-04-13 23:26 David Blaikie
2014-04-23 22:03 ` Doug Evans [this message]
2014-04-25  3:23   ` David Blaikie
2019-09-05 22:12     ` David Blaikie
2019-09-06  2:48       ` Christian Biesinger via gdb-patches
2019-09-06  4:17         ` Eric Christopher
2019-09-06 17:26           ` Christian Biesinger via gdb-patches
2019-09-06 20:23             ` David Blaikie
2019-09-06 20:25               ` Christian Biesinger via gdb-patches
     [not found]       ` <CADPb22Svrkdy6eOmcY2CxYAHfmaz_vRPE8sLDrujJCjbXCFMNg@mail.gmail.com>
2019-09-06 21:19         ` David Blaikie
2014-04-24 10:42 ` Pedro Alves

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=21336.14486.650610.274638@ruffy.mtv.corp.google.com \
    --to=dje@google.com \
    --cc=dblaikie@gmail.com \
    --cc=gdb-patches@sourceware.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox