From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 4728 invoked by alias); 23 Apr 2014 22:03:07 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 4717 invoked by uid 89); 23 Apr 2014 22:03:07 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-3.2 required=5.0 tests=AWL,BAYES_00,RCVD_IN_DNSWL_LOW,RP_MATCHES_RCVD,SPF_PASS autolearn=ham version=3.3.2 X-HELO: mail-ve0-f202.google.com Received: from mail-ve0-f202.google.com (HELO mail-ve0-f202.google.com) (209.85.128.202) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with (AES128-SHA encrypted) ESMTPS; Wed, 23 Apr 2014 22:03:05 +0000 Received: by mail-ve0-f202.google.com with SMTP id pa12so272834veb.5 for ; Wed, 23 Apr 2014 15:03:03 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:from:mime-version:content-type :content-transfer-encoding:message-id:date:to:cc:subject:in-reply-to :references; bh=ELzXEfs6Pkb8QN7U28MwYo6kYfoH2VKNr8Mtytsya9o=; b=hOb2ICd/eVQTfac1+CEl9byak+2uYmPIfvpcPZhRGVQC/ZX5Bid5tj8RflfA6c444I JuEiRBvHc0osDD11+RVse0i+lCF7pUL4c7O3M08Mr5ZFS/1yA6lmpGnMFiImDpfpd2fV qATCFFLL+GvPneIP4IuOYziq4gLCv5LII5vmh50p1c+BnRJjiOH0jIgOOb7Ok3McueA2 XvBdnoOg4F9T093sLsKBkHkdGVeIf/2KJA2mTZpwgJgggfs7RWd6PWDnIx+7wdns34WM UJh7EAh7Gu1Q/MIOoDzl8yAqR4+HzEQWLWZ8bY/4gAdF6bZwgRYJQGiKsctx+25YeL/G aBNw== X-Gm-Message-State: ALoCoQncVpJxl/zm6telfD9D6QW1HqX+JDurazdHK4COV4cRpf9u5XbXdBX2d6MEPxnSLrMvnB8688UlqrGabZwunRSw53U7FdktASZHN7qPeHO/1rpoC9TDPJCs/NYKFXOhUYcCvD8Zk2dchVepRGoeseazLJqTB9Ive/TuxZHt3QCx+CF6NJDvQ+K9pfdZ9xysbv7ZnHDFvO51m4IBvArba586zE+wmg== X-Received: by 10.236.180.2 with SMTP id i2mr22765450yhm.4.1398290583712; Wed, 23 Apr 2014 15:03:03 -0700 (PDT) Received: from corp2gmr1-2.hot.corp.google.com (corp2gmr1-2.hot.corp.google.com [172.24.189.93]) by gmr-mx.google.com with ESMTPS id x22si288555yhd.5.2014.04.23.15.03.03 for (version=TLSv1.1 cipher=ECDHE-RSA-AES128-SHA bits=128/128); Wed, 23 Apr 2014 15:03:03 -0700 (PDT) Received: from ruffy.mtv.corp.google.com (ruffy.mtv.corp.google.com [172.17.128.44]) by corp2gmr1-2.hot.corp.google.com (Postfix) with ESMTP id 306E15A4207; Wed, 23 Apr 2014 15:03:03 -0700 (PDT) From: Doug Evans MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Transfer-Encoding: 7bit Message-ID: <21336.14486.650610.274638@ruffy.mtv.corp.google.com> Date: Wed, 23 Apr 2014 22:03:00 -0000 To: David Blaikie Cc: gdb-patches Subject: Re: [patch] [gdb/testsuite] XFAIL under Clang tests using label debug info In-Reply-To: References: X-IsSubscribed: yes X-SW-Source: 2014-04/txt/msg00474.txt.bz2 David Blaikie writes: > Clang doesn't emit debug info for labels (Clang PR14500). XFAIL a > bunch of GDB tests that rely on debug info for labels. > > For some reason gdb.linespec/ls-expr.exp gathered all tests into a > dictionary and then ran them. This made it hard to XFAIL just the > right tests. I refactored this to execute the tests directly, removing > the dictionary so I could XFAIL the right tests. Is there a reason it > would've been written that way? Does my patch break it in some way? > commit c438cb16b63292e415330f289616c4e4ecece63c > Author: David Blaikie > Date: Sun Apr 13 11:42:02 2014 -0700 > > XFAIL under Clang tests using labels > > gdb/testsuite/ > * gdb.base/label.exp: XFAIL label related tests under Clang. > * gdb.cp/cplabel.exp: Ditto. > * gdb.linespec/ls-errs.exp: Refactor tests to execute directly > and XFAIL under Clang those using labels. LGTM > diff --git gdb/testsuite/ChangeLog gdb/testsuite/ChangeLog > index 730c116..b04b940 100644 > --- gdb/testsuite/ChangeLog > +++ gdb/testsuite/ChangeLog > @@ -1,3 +1,9 @@ > +2014-04-12 David Blaikie > + > + * gdb.base/label.exp: XFAIL label related tests under Clang. > + * gdb.cp/cplabel.exp: Ditto. > + * gdb.linespec/ls-errs.exp: Refactor tests to execute directly and XFAIL under Clang those using labels. > + Nit: space vs tabs. Just use tabs. Plus line is longer than 80 chars.