[PATCH] Use = instead of == for better portability

[PATCH] Use = instead of == for better portability

[Christian Biesinger]

[-- Attachment #1: Type: text/plain, Size: 220 bytes --]

Reported by sobukus on IRC.

gdb/testsuite/ChangeLog:

        * Makefile.in: Use = instead of = for test for
        portability.
---
 gdb/testsuite/Makefile.in | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

[-- Attachment #2: 0001-Use-instead-of-for-better-portability.patch --]
[-- Type: application/octet-stream, Size: 1227 bytes --]

From 4a39f2fd673b895d26a3aac01c5d4411718c635b Mon Sep 17 00:00:00 2001
From: Christian Biesinger <cbiesinger@google.com>
Date: Sat, 23 May 2020 13:09:16 -0500
Subject: [PATCH] Use = instead of == for better portability

Reported by sobukus on IRC.

gdb/testsuite/ChangeLog:

        * Makefile.in: Use = instead of = for test for
	portability.
---
 gdb/testsuite/Makefile.in | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/gdb/testsuite/Makefile.in b/gdb/testsuite/Makefile.in
index 0ba2eb42d5..dbe95b3491 100644
--- a/gdb/testsuite/Makefile.in
+++ b/gdb/testsuite/Makefile.in
@@ -209,7 +209,7 @@ check-single-racy:
 	-rm -rf cache racy_outputs temp
 	mkdir -p racy_outputs; \
 	racyiter="$(RACY_ITER)"; \
-	test "x$$racyiter" == "x" && \
+	test "x$$racyiter" = "x" && \
 	  racyiter=$(DEFAULT_RACY_ITER); \
 	if test $$racyiter -lt 2 ; then \
 	  echo "RACY_ITER must be at least 2."; \
@@ -239,7 +239,7 @@ check-parallel:
 check-parallel-racy:
 	-rm -rf cache racy_outputs temp
 	racyiter="$(RACY_ITER)"; \
-	test "x$$racyiter" == "x" && \
+	test "x$$racyiter" = "x" && \
 	  racyiter=$(DEFAULT_RACY_ITER); \
 	if test $$racyiter -lt 2 ; then \
 	  echo "RACY_ITER must be at least 2."; \
-- 
2.26.2

Re: [PATCH] Use = instead of == for better portability

[Tom Tromey]

>>>>> "Christian" == Christian Biesinger via Gdb-patches <gdb-patches@sourceware.org> writes:

Christian> Reported by sobukus on IRC.
Christian> gdb/testsuite/ChangeLog:

Christian>         * Makefile.in: Use = instead of = for test for
Christian>         portability.

Thanks, this is ok.

Tom

Re: [PATCH] Use = instead of == for better portability

[Tom de Vries]

On 23-05-2020 20:17, Christian Biesinger via Gdb-patches wrote:
> Reported by sobukus on IRC.
> 
> gdb/testsuite/ChangeLog:
> 
>         * Makefile.in: Use = instead of = for test for

Typo: "instead of =" -> "instead of ==".

>         portability.

Also, perhaps rephrase such that it becomes evident that you're
referring to the test command, rather than some generic test.

Thanks,
- Tom

Re: [PATCH] Use = instead of == for better portability

[Christian Biesinger]

On Sun, May 24, 2020 at 3:21 AM Tom de Vries <tdevries@suse.de> wrote:
>
> On 23-05-2020 20:17, Christian Biesinger via Gdb-patches wrote:
> > Reported by sobukus on IRC.
> >
> > gdb/testsuite/ChangeLog:
> >
> >         * Makefile.in: Use = instead of = for test for
>
> Typo: "instead of =" -> "instead of ==".
>
> >         portability.
>
> Also, perhaps rephrase such that it becomes evident that you're
> referring to the test command, rather than some generic test.

Thanks, pushed with those two things fixed.

Christian