From: Christian Biesinger <cbiesinger@google.com>
To: Tom de Vries <tdevries@suse.de>
Cc: gdb-patches <gdb-patches@sourceware.org>
Subject: Re: [PATCH] Use = instead of == for better portability
Date: Tue, 26 May 2020 12:00:05 -0500 [thread overview]
Message-ID: <CAPTJ0XE_P6_RD_32tnyCT0+U11ODgZjOa2p5Xfy7zDtPt-j+Hg@mail.gmail.com> (raw)
In-Reply-To: <a0d8b799-9dbd-b2c7-a2a4-03b6f8a58cd6@suse.de>
On Sun, May 24, 2020 at 3:21 AM Tom de Vries <tdevries@suse.de> wrote:
>
> On 23-05-2020 20:17, Christian Biesinger via Gdb-patches wrote:
> > Reported by sobukus on IRC.
> >
> > gdb/testsuite/ChangeLog:
> >
> > * Makefile.in: Use = instead of = for test for
>
> Typo: "instead of =" -> "instead of ==".
>
> > portability.
>
> Also, perhaps rephrase such that it becomes evident that you're
> referring to the test command, rather than some generic test.
Thanks, pushed with those two things fixed.
Christian
prev parent reply other threads:[~2020-05-26 17:00 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-05-23 18:17 Christian Biesinger
2020-05-23 20:47 ` Tom Tromey
2020-05-24 8:21 ` Tom de Vries
2020-05-26 17:00 ` Christian Biesinger [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CAPTJ0XE_P6_RD_32tnyCT0+U11ODgZjOa2p5Xfy7zDtPt-j+Hg@mail.gmail.com \
--to=cbiesinger@google.com \
--cc=gdb-patches@sourceware.org \
--cc=tdevries@suse.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox