From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-qk1-x744.google.com (mail-qk1-x744.google.com [IPv6:2607:f8b0:4864:20::744]) by sourceware.org (Postfix) with ESMTPS id 009C13851C0C for ; Tue, 26 May 2020 17:00:42 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.3.2 sourceware.org 009C13851C0C Received: by mail-qk1-x744.google.com with SMTP id c12so2430981qkk.13 for ; Tue, 26 May 2020 10:00:42 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=plxk/VjyxoQgP++bmBQn1qKHFKcQWuAW3xh6PzOPZ/c=; b=ltBVvXiH585yHVXBgFbGynvmSQZtoOkzehjF8M5XuVN4vcYKnGQkzTosCc7GdfoU/V mfonwmqsYzJnjymfb0vZNtlUhFc4K9WP86ekFho5K9mH68BomkKhXhvlL/MQfv/kWU48 7Wz3lXafmYuqa0KX4z95H8viB8lhOAt9uh0SyXNstHWKhMqOcfv3Y/GFyJ+gyjRPo+uo EzNOH7rBCPuEGsYKh1AATH3ekIXWXO1e+PVKdMDfnhxuoxat8rPDPVsydjCe1xsHfXz7 bMUQc0oGCwjHr7gg3nDa/gfEKzMabpcS+R+2X+OhwAdyHVwucxHg3dMVla8ChbDr2Nup yZpA== X-Gm-Message-State: AOAM531FtHatjBiNJh6D7qf0kFDXJBLuBKH2J9+phm8Ia+l8fgs4UgmT 53wJw/zMe3erG2ZWnlPkeHhQHx51NM3g9RvgNMC9ORyr X-Google-Smtp-Source: ABdhPJys+kt9FKIGyh0r0A/Xa4GM6R858IKMAn9yu0am48cuYNQ4v4skOouy1Lu1qDgoFV/ZYeZEgdNdMuVHcLv+r58= X-Received: by 2002:a37:6fc3:: with SMTP id k186mr2343420qkc.419.1590512442287; Tue, 26 May 2020 10:00:42 -0700 (PDT) MIME-Version: 1.0 References: In-Reply-To: From: Christian Biesinger Date: Tue, 26 May 2020 12:00:05 -0500 Message-ID: Subject: Re: [PATCH] Use = instead of == for better portability To: Tom de Vries Cc: gdb-patches Content-Type: text/plain; charset="UTF-8" X-Spam-Status: No, score=-19.9 required=5.0 tests=BAYES_00, DKIMWL_WL_MED, DKIM_SIGNED, DKIM_VALID, DKIM_VALID_AU, DKIM_VALID_EF, ENV_AND_HDR_SPF_MATCH, RCVD_IN_DNSWL_NONE, SPF_HELO_NONE, SPF_PASS, TXREP, USER_IN_DEF_DKIM_WL, USER_IN_DEF_SPF_WL autolearn=ham autolearn_force=no version=3.4.2 X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on server2.sourceware.org X-BeenThere: gdb-patches@sourceware.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Gdb-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 26 May 2020 17:00:44 -0000 On Sun, May 24, 2020 at 3:21 AM Tom de Vries wrote: > > On 23-05-2020 20:17, Christian Biesinger via Gdb-patches wrote: > > Reported by sobukus on IRC. > > > > gdb/testsuite/ChangeLog: > > > > * Makefile.in: Use = instead of = for test for > > Typo: "instead of =" -> "instead of ==". > > > portability. > > Also, perhaps rephrase such that it becomes evident that you're > referring to the test command, rather than some generic test. Thanks, pushed with those two things fixed. Christian