Mirror of the gdb-patches mailing list
 help / color / mirror / Atom feed
From: Doug Evans <dje@google.com>
To: Romain Naour <romain.naour@openwide.fr>,
	gdb-patches <gdb-patches@sourceware.org>,
		Yao Qi <yao.qi@linaro.org>,
	Thomas Petazzoni <thomas.petazzoni@free-electrons.com>
Subject: Re: [PATCH] [RFC] gdb: add disable-docs option
Date: Thu, 24 Sep 2015 21:47:00 -0000	[thread overview]
Message-ID: <CADPb22T=r=hUUrAdr2WK_Xb=Bywwvx8svvNUP-2MHqSwf78KrQ@mail.gmail.com> (raw)
In-Reply-To: <20150924211221.GA10729@vapier.lan>

On Thu, Sep 24, 2015 at 2:12 PM, Mike Frysinger <vapier@gentoo.org> wrote:
> On 06 Sep 2015 11:37, Romain Naour wrote:
>> If makeinfo is not found in the system then the missing
>> script is used to warn the user.
>>
>> Before commit e30465112ed4c6320dd19107302057a5f7712cf2 the missing
>> script returned 0 after printing the message.
>>
>> Now, missing return 127 (command not found) to the Makefile and
>> the build fail.
>>
>> As suggested [1], add a new option to disable the documentation.
>
> aren't info pages shipped as part of the release ?  so even if makeinfo isn't
> available, it doesn't matter as the pages aren't regenerated on the user's
> system.  maybe you're applying patches to the source that cause the docs to be
> regenerated ?  if that's the case, i think disabling the docs entirely is the
> wrong way to go.  instead it should be skipping the regeneration step and
> installing the pages that already exist.  alternatively, you can adjust your
> build to update the timestamps of the generated files so the build won't try
> to regenerate them.
> -mike

Agreed.

Sometimes releases have gone out with bad timestamps which need to be
fixed, but yeah there should be no need to disable doc generation.


  reply	other threads:[~2015-09-24 21:47 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
     [not found] <1441532245-23124-1-git-send-email-romain.naour@openwide.fr>
2015-09-24 20:10 ` Romain Naour
2015-09-24 21:12 ` Mike Frysinger
2015-09-24 21:47   ` Doug Evans [this message]
2015-09-25  8:58     ` Romain Naour
2015-09-25 11:50       ` Simon Marchi
2015-09-25 13:53       ` Mike Frysinger

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to='CADPb22T=r=hUUrAdr2WK_Xb=Bywwvx8svvNUP-2MHqSwf78KrQ@mail.gmail.com' \
    --to=dje@google.com \
    --cc=gdb-patches@sourceware.org \
    --cc=romain.naour@openwide.fr \
    --cc=thomas.petazzoni@free-electrons.com \
    --cc=yao.qi@linaro.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox