From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 115099 invoked by alias); 24 Sep 2015 21:47:03 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 115081 invoked by uid 89); 24 Sep 2015 21:47:02 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-2.6 required=5.0 tests=AWL,BAYES_00,RCVD_IN_DNSWL_LOW,RP_MATCHES_RCVD,SPF_PASS autolearn=ham version=3.3.2 X-HELO: mail-ig0-f171.google.com Received: from mail-ig0-f171.google.com (HELO mail-ig0-f171.google.com) (209.85.213.171) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with (AES128-GCM-SHA256 encrypted) ESMTPS; Thu, 24 Sep 2015 21:47:01 +0000 Received: by igcrk20 with SMTP id rk20so1214430igc.1 for ; Thu, 24 Sep 2015 14:46:59 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:mime-version:in-reply-to:references:from:date :message-id:subject:to:content-type; bh=K5usLI34MBHIXDj2scutYGmXHSk5gk92C9hHZD+F1BM=; b=Og8xh9gQmTpYmPmcXo11xXhA+4l12CQ8a/ckGrdBmY7XGeVoHQ+r5VuC2Ccljx5oWa F2ylp1fkyxfldL4uYf6QJLmJx7nppqQvUeENI1RIfXsyHNgrHk0BpiQFrI7wUiohkDN8 Uev+jiPBksy2KPy4F5LIHQBgO0Id/u8JPRteN1Vj+9X99BGgY4HLJv/aokYBWBDd33jX 4ZpSHJub14jWFj21uhZx52guHsMglLAbPtsVhH79C4lRwZG2A4g/frlJoDc3zGVE7u17 WiNzxoNRyIFdWvxQot21wZAQWjvkA9DMs4GElxThjMB0VHXv5WR4CzplsY+NyAsyQocp 4/3g== X-Gm-Message-State: ALoCoQmLIFMvad7w5qbPPk8PyIKRp5DcvIBPudsYsnm+x/vU9JA/I5ZJkXYIFBQ3Nus4d01yAoNP X-Received: by 10.50.79.229 with SMTP id m5mr30484646igx.1.1443131219490; Thu, 24 Sep 2015 14:46:59 -0700 (PDT) MIME-Version: 1.0 Received: by 10.64.19.130 with HTTP; Thu, 24 Sep 2015 14:46:19 -0700 (PDT) In-Reply-To: <20150924211221.GA10729@vapier.lan> References: <1441532245-23124-1-git-send-email-romain.naour@openwide.fr> <20150924211221.GA10729@vapier.lan> From: Doug Evans Date: Thu, 24 Sep 2015 21:47:00 -0000 Message-ID: Subject: Re: [PATCH] [RFC] gdb: add disable-docs option To: Romain Naour , gdb-patches , Yao Qi , Thomas Petazzoni Content-Type: text/plain; charset=UTF-8 X-IsSubscribed: yes X-SW-Source: 2015-09/txt/msg00565.txt.bz2 On Thu, Sep 24, 2015 at 2:12 PM, Mike Frysinger wrote: > On 06 Sep 2015 11:37, Romain Naour wrote: >> If makeinfo is not found in the system then the missing >> script is used to warn the user. >> >> Before commit e30465112ed4c6320dd19107302057a5f7712cf2 the missing >> script returned 0 after printing the message. >> >> Now, missing return 127 (command not found) to the Makefile and >> the build fail. >> >> As suggested [1], add a new option to disable the documentation. > > aren't info pages shipped as part of the release ? so even if makeinfo isn't > available, it doesn't matter as the pages aren't regenerated on the user's > system. maybe you're applying patches to the source that cause the docs to be > regenerated ? if that's the case, i think disabling the docs entirely is the > wrong way to go. instead it should be skipping the regeneration step and > installing the pages that already exist. alternatively, you can adjust your > build to update the timestamps of the generated files so the build won't try > to regenerate them. > -mike Agreed. Sometimes releases have gone out with bad timestamps which need to be fixed, but yeah there should be no need to disable doc generation.