Re: [PATCH] [RFC] gdb: add disable-docs option

[Simon Marchi <simon.marchi@ericsson.com>]

On 15-09-25 04:58 AM, Romain Naour wrote:
> Hello,
> 
> Thanks for your reply!
> 
> Le 24/09/2015 23:46, Doug Evans a écrit :
>> On Thu, Sep 24, 2015 at 2:12 PM, Mike Frysinger <vapier@gentoo.org> wrote:
>>> On 06 Sep 2015 11:37, Romain Naour wrote:
>>>> If makeinfo is not found in the system then the missing
>>>> script is used to warn the user.
>>>>
>>>> Before commit e30465112ed4c6320dd19107302057a5f7712cf2 the missing
>>>> script returned 0 after printing the message.
>>>>
>>>> Now, missing return 127 (command not found) to the Makefile and
>>>> the build fail.
>>>>
>>>> As suggested [1], add a new option to disable the documentation.
>>>
>>> aren't info pages shipped as part of the release ?  so even if makeinfo isn't
>>> available, it doesn't matter as the pages aren't regenerated on the user's
>>> system.  maybe you're applying patches to the source that cause the docs to be
>>> regenerated ?  if that's the case, i think disabling the docs entirely is the
>>> wrong way to go.  instead it should be skipping the regeneration step and
>>> installing the pages that already exist.  alternatively, you can adjust your
>>> build to update the timestamps of the generated files so the build won't try
>>> to regenerate them.
>>> -mike
>>
>> Agreed.
>>
>> Sometimes releases have gone out with bad timestamps which need to be
>> fixed, but yeah there should be no need to disable doc generation.
>>
> 
> Actually, I really want to disable the documentation entirely since all
> documentation installed by packages (like gdb) are automatically removed from
> the generated filesystem at the end of the build (see [1] and [2]).
> 
> Until gdb 7.8, ac_cv_prog_MAKEINFO=missing was used to workaround the build
> issue when makeinfo was missing. But it's not enough since gdb 7.9.
> 
> Best regards,
> Romain Naour
> 
> [1] http://buildroot.uclibc.org/downloads/manual/manual.html#faq-no-doc-on-target
> 
> [2] http://git.buildroot.net/buildroot/tree/Makefile#n559

I don't know if this is acceptable, but I managed to effectively disable building
of the doc by setting MAKEINFO=true (as in /bin/true) during the build.

See http://git.eclipse.org/c/cdt/org.eclipse.cdt.git/tree/dsf-gdb/org.eclipse.cdt.tests.dsf.gdb/scripts/download-build-gdb.sh