Re: [PATCH] not trigger pagination with dprintf

[Doug Evans <dje@google.com>]

On Tue, May 7, 2013 at 9:38 AM, Eli Zaretskii <eliz@gnu.org> wrote:
>> From: Hui Zhu <teawater@gmail.com>
>> Date: Tue, 7 May 2013 10:29:39 +0800
>> Cc: Tom Tromey <tromey@redhat.com>, gdb-patches ml <gdb-patches@sourceware.org>,
>>       Eli Zaretskii <eliz@gnu.org>
>>
>> --- a/gdb/NEWS
>> +++ b/gdb/NEWS
>> @@ -51,6 +51,9 @@ show remote trace-status-packet
>>    ** The -trace-save MI command can optionally save trace buffer in Common
>>       Trace Format now.
>>
>> +* When GDB executes the commands of any breakpoint, the GDB output
>> +  pagination will be auto set to off.
>                         ^^^^
> "automatically"

I would add "... set to off for the duration of the breakpoint commands."
or something like that.

>> --- a/gdb/doc/gdb.texinfo
>> +++ b/gdb/doc/gdb.texinfo
>> @@ -4619,6 +4619,9 @@ commands to execute when your program st
>>  example, you might want to print the values of certain expressions, or
>>  enable other breakpoints.
>>
>> +When @value{GDBN} executes the commands of any breakpoint,
>> +the @value{GDBN} output pagination will be auto set to off.
>                                               ^^^^
> Same here.

nit: I previously mentioned adding a note saying that any change to
pagination done by the user during breakpoint commands is reverted,
but that was left out.

> OK with these changes.
>
> Thanks.

Plus, for reference sake, we still haven't decided to go this route.
I'm kinda on the fence, and I'd like to hear what other GMs think.

[I realize you're just reviewing the doc parts (and thanks for that).]