Mirror of the gdb-patches mailing list
 help / color / mirror / Atom feed
From: Tom Tromey <tromey@redhat.com>
To: Hui Zhu <teawater@gmail.com>
Cc: gdb-patches ml <gdb-patches@sourceware.org>
Subject: Re: [PATCH] not trigger pagination with dprintf
Date: Sat, 20 Apr 2013 08:20:00 -0000	[thread overview]
Message-ID: <87zjwuv0qn.fsf@fleche.redhat.com> (raw)
In-Reply-To: <CANFwon2V2vVADH89czoQjS+F=Uxsc5AgMAsQ3=d0nohc2EfBpA@mail.gmail.com>	(Hui Zhu's message of "Thu, 18 Apr 2013 16:57:50 +0800")

>>>>> "Hui" == Hui Zhu <teawater@gmail.com> writes:

Hui> This is the patch for http://sourceware.org/bugzilla/show_bug.cgi?id=15182
Hui> I agree with what Marc said in the bug report.

Quoting for clarity:

   a) when pagination is triggered, inferior execution will be
      interrupted until the user answers the pagination prompt

   b) pagination is triggered by the dprintf but not by real inferior
      output. So, as dprintf and inferior printouts appear interleaved
      on the screen, the pagination prompt will be triggered when the
      dprintfs add up to too many, which will seem random to the user,
      since the other printouts are also visible.


I agree these arguments are pretty good, but I don't see why they apply
particularly to dprintf as opposed to all gdb output.  But then the
result is to just disable all pagination -- something already easily
done.

So I tend to think this should not go in.

FWIW I have never understood why gdb provides _unfiltered variants of
the print functions.  It seems to me that a stream should either be
paginated or not -- having it work at the level of the individual print
means that some prints will provoke paging behavior and some will not;
and, worse, since they are in fact interleaved, the "paging" output may
not all be visible anyhow.

Tom


  reply	other threads:[~2013-04-19 18:23 UTC|newest]

Thread overview: 16+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2013-04-19  3:22 Hui Zhu
2013-04-20  8:20 ` Tom Tromey [this message]
2013-04-22  9:21   ` Hui Zhu
2013-04-25  8:02     ` Tom Tromey
2013-04-26 13:55       ` Hui Zhu
2013-04-26 14:14         ` Yao Qi
2013-04-27 11:40         ` Tom Tromey
2013-04-30 11:12           ` Hui Zhu
2013-05-04  4:41             ` Doug Evans
2013-05-07  2:30               ` Hui Zhu
2013-05-07 16:39                 ` Eli Zaretskii
2013-05-07 17:01                   ` Doug Evans
2013-05-07 18:08                     ` Tom Tromey
2013-05-07 18:10                       ` Doug Evans
2013-05-07 18:28                         ` Eli Zaretskii
2013-05-10 11:21                           ` Hui Zhu

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=87zjwuv0qn.fsf@fleche.redhat.com \
    --to=tromey@redhat.com \
    --cc=gdb-patches@sourceware.org \
    --cc=teawater@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox