From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 371 invoked by alias); 19 Apr 2013 18:23:00 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 361 invoked by uid 89); 19 Apr 2013 18:23:00 -0000 X-Spam-SWARE-Status: No, score=-6.9 required=5.0 tests=AWL,BAYES_00,KHOP_RCVD_UNTRUST,RCVD_IN_DNSWL_HI,RCVD_IN_HOSTKARMA_W,RP_MATCHES_RCVD,SPF_HELO_PASS autolearn=ham version=3.3.1 Received: from mx1.redhat.com (HELO mx1.redhat.com) (209.132.183.28) by sourceware.org (qpsmtpd/0.84/v0.84-167-ge50287c) with ESMTP; Fri, 19 Apr 2013 18:22:59 +0000 Received: from int-mx11.intmail.prod.int.phx2.redhat.com (int-mx11.intmail.prod.int.phx2.redhat.com [10.5.11.24]) by mx1.redhat.com (8.14.4/8.14.4) with ESMTP id r3JIMvob006248 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=OK); Fri, 19 Apr 2013 14:22:57 -0400 Received: from barimba (ovpn01.gateway.prod.ext.phx2.redhat.com [10.5.9.1]) by int-mx11.intmail.prod.int.phx2.redhat.com (8.14.4/8.14.4) with ESMTP id r3JIMuSU030531 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES128-SHA bits=128 verify=NO); Fri, 19 Apr 2013 14:22:57 -0400 From: Tom Tromey To: Hui Zhu Cc: gdb-patches ml Subject: Re: [PATCH] not trigger pagination with dprintf References: Date: Sat, 20 Apr 2013 08:20:00 -0000 In-Reply-To: (Hui Zhu's message of "Thu, 18 Apr 2013 16:57:50 +0800") Message-ID: <87zjwuv0qn.fsf@fleche.redhat.com> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/24.3 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-SW-Source: 2013-04/txt/msg00628.txt.bz2 >>>>> "Hui" == Hui Zhu writes: Hui> This is the patch for http://sourceware.org/bugzilla/show_bug.cgi?id=15182 Hui> I agree with what Marc said in the bug report. Quoting for clarity: a) when pagination is triggered, inferior execution will be interrupted until the user answers the pagination prompt b) pagination is triggered by the dprintf but not by real inferior output. So, as dprintf and inferior printouts appear interleaved on the screen, the pagination prompt will be triggered when the dprintfs add up to too many, which will seem random to the user, since the other printouts are also visible. I agree these arguments are pretty good, but I don't see why they apply particularly to dprintf as opposed to all gdb output. But then the result is to just disable all pagination -- something already easily done. So I tend to think this should not go in. FWIW I have never understood why gdb provides _unfiltered variants of the print functions. It seems to me that a stream should either be paginated or not -- having it work at the level of the individual print means that some prints will provoke paging behavior and some will not; and, worse, since they are in fact interleaved, the "paging" output may not all be visible anyhow. Tom