From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 5512 invoked by alias); 7 May 2013 17:01:30 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 5490 invoked by uid 89); 7 May 2013 17:01:26 -0000 X-Spam-SWARE-Status: No, score=-4.6 required=5.0 tests=AWL,BAYES_00,KHOP_THREADED,RCVD_IN_DNSWL_LOW,RCVD_IN_HOSTKARMA_YE,RP_MATCHES_RCVD,SPF_PASS autolearn=ham version=3.3.1 Received: from mail-vc0-f182.google.com (HELO mail-vc0-f182.google.com) (209.85.220.182) by sourceware.org (qpsmtpd/0.84/v0.84-167-ge50287c) with ESMTP; Tue, 07 May 2013 17:01:25 +0000 Received: by mail-vc0-f182.google.com with SMTP id ia10so740456vcb.41 for ; Tue, 07 May 2013 10:01:23 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20120113; h=mime-version:x-received:in-reply-to:references:date:message-id :subject:from:to:cc:content-type:x-gm-message-state; bh=qeI/LgAlbvbZSjchWJDMasNcE1dtbYkxagxwF2plzb8=; b=Gzer8GBJY40Kc/mM8bgYDjm8JLrHLQma9j81lkhlVlIKJuoyEt1GofWL9L/FVdaaQw Dazx+hRVr+K7GN6rTUfKg8frqqiiNtHVyqGtx2rUH4SKEdnNCcwRmt/LZS4tIVybaW3y bZcVaEqe/e/g41/n1SeXOlwpseWj+Qp3LSWeYcb5aH38iyrntb2dtj60KlacijV9Eblv mLoVlzjH3wos0e5GXSA7doLRx8KeWDRZPh/y9SQC5397/O9jB9DNPrC0rHGpHq/8T63B KWULiLO+GrCXnLgt7OAt9L0xDW5CH/vBf9i98fD7vPZiwMQGBa5KWfRM9/fuyzKrgffF Qi/g== MIME-Version: 1.0 X-Received: by 10.52.24.113 with SMTP id t17mr1607631vdf.30.1367946083557; Tue, 07 May 2013 10:01:23 -0700 (PDT) Received: by 10.220.173.7 with HTTP; Tue, 7 May 2013 10:01:23 -0700 (PDT) In-Reply-To: <83k3naeodd.fsf@gnu.org> References: <87zjwuv0qn.fsf@fleche.redhat.com> <87li87ll0r.fsf@fleche.redhat.com> <87fvyd827o.fsf@fleche.redhat.com> <83k3naeodd.fsf@gnu.org> Date: Tue, 07 May 2013 17:01:00 -0000 Message-ID: Subject: Re: [PATCH] not trigger pagination with dprintf From: Doug Evans To: Eli Zaretskii Cc: Hui Zhu , Tom Tromey , gdb-patches Content-Type: text/plain; charset=ISO-8859-1 X-Gm-Message-State: ALoCoQnk9kalrvhYdTIGI/aDRZNfpyZiJyjELwf9EuJWhKg0ChaqI1CwzU+QvdBBvmchrmahacJSpjkDXi+LZN3bretTrNE2Y5vTLJ13U/fjb6F4Cf/rSjnaCx7zrSiBQJtPQqtAEpSHPxqQn95a0Nez9UU8sey5NOQCia/iLE50gFV/SLsMlw6gI7URPA/9dMIxnCiRU4tPhlbI2W9NB9TRF+1LXaMX2w== X-SW-Source: 2013-05/txt/msg00246.txt.bz2 On Tue, May 7, 2013 at 9:38 AM, Eli Zaretskii wrote: >> From: Hui Zhu >> Date: Tue, 7 May 2013 10:29:39 +0800 >> Cc: Tom Tromey , gdb-patches ml , >> Eli Zaretskii >> >> --- a/gdb/NEWS >> +++ b/gdb/NEWS >> @@ -51,6 +51,9 @@ show remote trace-status-packet >> ** The -trace-save MI command can optionally save trace buffer in Common >> Trace Format now. >> >> +* When GDB executes the commands of any breakpoint, the GDB output >> + pagination will be auto set to off. > ^^^^ > "automatically" I would add "... set to off for the duration of the breakpoint commands." or something like that. >> --- a/gdb/doc/gdb.texinfo >> +++ b/gdb/doc/gdb.texinfo >> @@ -4619,6 +4619,9 @@ commands to execute when your program st >> example, you might want to print the values of certain expressions, or >> enable other breakpoints. >> >> +When @value{GDBN} executes the commands of any breakpoint, >> +the @value{GDBN} output pagination will be auto set to off. > ^^^^ > Same here. nit: I previously mentioned adding a note saying that any change to pagination done by the user during breakpoint commands is reverted, but that was left out. > OK with these changes. > > Thanks. Plus, for reference sake, we still haven't decided to go this route. I'm kinda on the fence, and I'd like to hear what other GMs think. [I realize you're just reviewing the doc parts (and thanks for that).]