From: Doug Evans <dje@google.com>
To: Yao Qi <yao@codesourcery.com>
Cc: gdb-patches <gdb-patches@sourceware.org>
Subject: Re: [PATCH 1/3] Import mkdir module
Date: Tue, 19 Mar 2013 16:32:00 -0000 [thread overview]
Message-ID: <CADPb22Rvf6Ky4N_p8ELQy=wJ=+YN2Yf7qe+Te3H_=cFB45Pk-w@mail.gmail.com> (raw)
In-Reply-To: <1363407692-18959-2-git-send-email-yao@codesourcery.com>
On Fri, Mar 15, 2013 at 9:21 PM, Yao Qi <yao@codesourcery.com> wrote:
> Here are my steps to import mkdir module into GDB gnulib.
>
> 1. Check out my gulib repository to
> 8d5bd1402003bd0153984b138735adf537d960b0, which is required by
> update-gnulib.sh, so that we just import mkdir module instead
> of upgrading gnulib we are using.
> 2. Modify update-gnulib.sh to add mkdir.
> 3. bash update-gnulib.sh <my gnulib repository>
>
> Build GDB with all-targets enabled and cross compile GDB for mingw32
> target.
Hi.
A ton of random stuff got dragged in.
Is this typical of gnulib?
Including, but not limited to, the following.
If all this extra stuff is just due to updating to a newer version of
gnulib, please separate out the update from the addition of mkdir.
>
> +/* Define to 1 if canonicalize_file_name is declared even after undefining
> + macros. */
> +#undef HAVE_RAW_DECL_CANONICALIZE_FILE_NAME
> +
> +/* Define to 1 if chdir is declared even after undefining macros. */
> +#undef HAVE_RAW_DECL_CHDIR
> +
> +/* Define to 1 if chown is declared even after undefining macros. */
> +#undef HAVE_RAW_DECL_CHOWN
> +
> +/* Define to 1 if dup is declared even after undefining macros. */
> +#undef HAVE_RAW_DECL_DUP
> +
> +/* Define to 1 if dup2 is declared even after undefining macros. */
> +#undef HAVE_RAW_DECL_DUP2
> +
> +/* Define to 1 if dup3 is declared even after undefining macros. */
> +#undef HAVE_RAW_DECL_DUP3
> +
> +/* Define to 1 if endusershell is declared even after undefining macros. */
> +#undef HAVE_RAW_DECL_ENDUSERSHELL
> +
> +/* Define to 1 if environ is declared even after undefining macros. */
> +#undef HAVE_RAW_DECL_ENVIRON
> +
> +/* Define to 1 if euidaccess is declared even after undefining macros. */
> +#undef HAVE_RAW_DECL_EUIDACCESS
> +
> +/* Define to 1 if faccessat is declared even after undefining macros. */
> +#undef HAVE_RAW_DECL_FACCESSAT
> +
> +/* Define to 1 if fchdir is declared even after undefining macros. */
> +#undef HAVE_RAW_DECL_FCHDIR
> +
> +/* Define to 1 if fchmodat is declared even after undefining macros. */
> +#undef HAVE_RAW_DECL_FCHMODAT
> +
> +/* Define to 1 if fchownat is declared even after undefining macros. */
> +#undef HAVE_RAW_DECL_FCHOWNAT
> +
> +/* Define to 1 if fdatasync is declared even after undefining macros. */
> +#undef HAVE_RAW_DECL_FDATASYNC
> +
> /* Define to 1 if ffsl is declared even after undefining macros. */
> #undef HAVE_RAW_DECL_FFSL
>
> /* Define to 1 if ffsll is declared even after undefining macros. */
> #undef HAVE_RAW_DECL_FFSLL
>
> +/* Define to 1 if fstat is declared even after undefining macros. */
> +#undef HAVE_RAW_DECL_FSTAT
> +
> +/* Define to 1 if fstatat is declared even after undefining macros. */
> +#undef HAVE_RAW_DECL_FSTATAT
> +
> +/* Define to 1 if fsync is declared even after undefining macros. */
> +#undef HAVE_RAW_DECL_FSYNC
> +
> +/* Define to 1 if ftruncate is declared even after undefining macros. */
> +#undef HAVE_RAW_DECL_FTRUNCATE
> +
> +/* Define to 1 if futimens is declared even after undefining macros. */
> +#undef HAVE_RAW_DECL_FUTIMENS
> +
> +/* Define to 1 if getcwd is declared even after undefining macros. */
> +#undef HAVE_RAW_DECL_GETCWD
> +
> +/* Define to 1 if getdomainname is declared even after undefining macros. */
> +#undef HAVE_RAW_DECL_GETDOMAINNAME
> +
> +/* Define to 1 if getdtablesize is declared even after undefining macros. */
> +#undef HAVE_RAW_DECL_GETDTABLESIZE
> +
> +/* Define to 1 if getgroups is declared even after undefining macros. */
> +#undef HAVE_RAW_DECL_GETGROUPS
> +
> +/* Define to 1 if gethostname is declared even after undefining macros. */
> +#undef HAVE_RAW_DECL_GETHOSTNAME
> +
> +/* Define to 1 if getloadavg is declared even after undefining macros. */
> +#undef HAVE_RAW_DECL_GETLOADAVG
> +
> +/* Define to 1 if getlogin is declared even after undefining macros. */
> +#undef HAVE_RAW_DECL_GETLOGIN
> +
> +/* Define to 1 if getlogin_r is declared even after undefining macros. */
> +#undef HAVE_RAW_DECL_GETLOGIN_R
> +
> +/* Define to 1 if getpagesize is declared even after undefining macros. */
> +#undef HAVE_RAW_DECL_GETPAGESIZE
> +
> +/* Define to 1 if getsubopt is declared even after undefining macros. */
> +#undef HAVE_RAW_DECL_GETSUBOPT
> +
> +/* Define to 1 if getusershell is declared even after undefining macros. */
> +#undef HAVE_RAW_DECL_GETUSERSHELL
> +
> +/* Define to 1 if grantpt is declared even after undefining macros. */
> +#undef HAVE_RAW_DECL_GRANTPT
> +
> +/* Define to 1 if group_member is declared even after undefining macros. */
> +#undef HAVE_RAW_DECL_GROUP_MEMBER
> +
> /* Define to 1 if imaxabs is declared even after undefining macros. */
> #undef HAVE_RAW_DECL_IMAXABS
>
> /* Define to 1 if imaxdiv is declared even after undefining macros. */
> #undef HAVE_RAW_DECL_IMAXDIV
>
> +/* Define to 1 if initstate is declared even after undefining macros. */
> +#undef HAVE_RAW_DECL_INITSTATE
> +
> +/* Define to 1 if initstate_r is declared even after undefining macros. */
> +#undef HAVE_RAW_DECL_INITSTATE_R
> +
> +/* Define to 1 if isatty is declared even after undefining macros. */
> +#undef HAVE_RAW_DECL_ISATTY
> +
> /* Define to 1 if iswctype is declared even after undefining macros. */
> #undef HAVE_RAW_DECL_ISWCTYPE
>
> +/* Define to 1 if lchmod is declared even after undefining macros. */
> +#undef HAVE_RAW_DECL_LCHMOD
> +
> +/* Define to 1 if lchown is declared even after undefining macros. */
> +#undef HAVE_RAW_DECL_LCHOWN
> +
> +/* Define to 1 if link is declared even after undefining macros. */
> +#undef HAVE_RAW_DECL_LINK
> +
> +/* Define to 1 if linkat is declared even after undefining macros. */
> +#undef HAVE_RAW_DECL_LINKAT
> +
> +/* Define to 1 if lseek is declared even after undefining macros. */
> +#undef HAVE_RAW_DECL_LSEEK
> +
> +/* Define to 1 if lstat is declared even after undefining macros. */
> +#undef HAVE_RAW_DECL_LSTAT
> +
> /* Define to 1 if mbrlen is declared even after undefining macros. */
> #undef HAVE_RAW_DECL_MBRLEN
>
> @@ -171,9 +311,108 @@
> /* Define to 1 if memrchr is declared even after undefining macros. */
> #undef HAVE_RAW_DECL_MEMRCHR
>
> +/* Define to 1 if mkdirat is declared even after undefining macros. */
> +#undef HAVE_RAW_DECL_MKDIRAT
> +
> +/* Define to 1 if mkdtemp is declared even after undefining macros. */
> +#undef HAVE_RAW_DECL_MKDTEMP
> +
> +/* Define to 1 if mkfifo is declared even after undefining macros. */
> +#undef HAVE_RAW_DECL_MKFIFO
> +
> +/* Define to 1 if mkfifoat is declared even after undefining macros. */
> +#undef HAVE_RAW_DECL_MKFIFOAT
> +
> +/* Define to 1 if mknod is declared even after undefining macros. */
> +#undef HAVE_RAW_DECL_MKNOD
> +
> +/* Define to 1 if mknodat is declared even after undefining macros. */
> +#undef HAVE_RAW_DECL_MKNODAT
> +
> +/* Define to 1 if mkostemp is declared even after undefining macros. */
> +#undef HAVE_RAW_DECL_MKOSTEMP
> +
> +/* Define to 1 if mkostemps is declared even after undefining macros. */
> +#undef HAVE_RAW_DECL_MKOSTEMPS
> +
> +/* Define to 1 if mkstemp is declared even after undefining macros. */
> +#undef HAVE_RAW_DECL_MKSTEMP
> +
> +/* Define to 1 if mkstemps is declared even after undefining macros. */
> +#undef HAVE_RAW_DECL_MKSTEMPS
> +
> +/* Define to 1 if pipe is declared even after undefining macros. */
> +#undef HAVE_RAW_DECL_PIPE
> +
> +/* Define to 1 if pipe2 is declared even after undefining macros. */
> +#undef HAVE_RAW_DECL_PIPE2
> +
> +/* Define to 1 if posix_openpt is declared even after undefining macros. */
> +#undef HAVE_RAW_DECL_POSIX_OPENPT
> +
> +/* Define to 1 if pread is declared even after undefining macros. */
> +#undef HAVE_RAW_DECL_PREAD
> +
> +/* Define to 1 if ptsname is declared even after undefining macros. */
> +#undef HAVE_RAW_DECL_PTSNAME
> +
> +/* Define to 1 if ptsname_r is declared even after undefining macros. */
> +#undef HAVE_RAW_DECL_PTSNAME_R
> +
> +/* Define to 1 if pwrite is declared even after undefining macros. */
> +#undef HAVE_RAW_DECL_PWRITE
> +
> +/* Define to 1 if random is declared even after undefining macros. */
> +#undef HAVE_RAW_DECL_RANDOM
> +
> +/* Define to 1 if random_r is declared even after undefining macros. */
> +#undef HAVE_RAW_DECL_RANDOM_R
> +
> /* Define to 1 if rawmemchr is declared even after undefining macros. */
> #undef HAVE_RAW_DECL_RAWMEMCHR
>
> +/* Define to 1 if readlink is declared even after undefining macros. */
> +#undef HAVE_RAW_DECL_READLINK
> +
> +/* Define to 1 if readlinkat is declared even after undefining macros. */
> +#undef HAVE_RAW_DECL_READLINKAT
> +
> +/* Define to 1 if realpath is declared even after undefining macros. */
> +#undef HAVE_RAW_DECL_REALPATH
> +
> +/* Define to 1 if rmdir is declared even after undefining macros. */
> +#undef HAVE_RAW_DECL_RMDIR
> +
> +/* Define to 1 if rpmatch is declared even after undefining macros. */
> +#undef HAVE_RAW_DECL_RPMATCH
> +
> +/* Define to 1 if setenv is declared even after undefining macros. */
> +#undef HAVE_RAW_DECL_SETENV
> +
> +/* Define to 1 if sethostname is declared even after undefining macros. */
> +#undef HAVE_RAW_DECL_SETHOSTNAME
> +
> +/* Define to 1 if setstate is declared even after undefining macros. */
> +#undef HAVE_RAW_DECL_SETSTATE
> +
> +/* Define to 1 if setstate_r is declared even after undefining macros. */
> +#undef HAVE_RAW_DECL_SETSTATE_R
> +
> +/* Define to 1 if setusershell is declared even after undefining macros. */
> +#undef HAVE_RAW_DECL_SETUSERSHELL
> +
> +/* Define to 1 if sleep is declared even after undefining macros. */
> +#undef HAVE_RAW_DECL_SLEEP
> +
> +/* Define to 1 if srandom is declared even after undefining macros. */
> +#undef HAVE_RAW_DECL_SRANDOM
> +
> +/* Define to 1 if srandom_r is declared even after undefining macros. */
> +#undef HAVE_RAW_DECL_SRANDOM_R
> +
> +/* Define to 1 if stat is declared even after undefining macros. */
> +#undef HAVE_RAW_DECL_STAT
> +
> /* Define to 1 if stpcpy is declared even after undefining macros. */
> #undef HAVE_RAW_DECL_STPCPY
>
> @@ -210,21 +449,57 @@
> /* Define to 1 if strsignal is declared even after undefining macros. */
> #undef HAVE_RAW_DECL_STRSIGNAL
>
> +/* Define to 1 if strtod is declared even after undefining macros. */
> +#undef HAVE_RAW_DECL_STRTOD
> +
> /* Define to 1 if strtoimax is declared even after undefining macros. */
> #undef HAVE_RAW_DECL_STRTOIMAX
>
> /* Define to 1 if strtok_r is declared even after undefining macros. */
> #undef HAVE_RAW_DECL_STRTOK_R
>
> +/* Define to 1 if strtoll is declared even after undefining macros. */
> +#undef HAVE_RAW_DECL_STRTOLL
> +
> +/* Define to 1 if strtoull is declared even after undefining macros. */
> +#undef HAVE_RAW_DECL_STRTOULL
> +
> /* Define to 1 if strtoumax is declared even after undefining macros. */
> #undef HAVE_RAW_DECL_STRTOUMAX
>
> /* Define to 1 if strverscmp is declared even after undefining macros. */
> #undef HAVE_RAW_DECL_STRVERSCMP
>
> +/* Define to 1 if symlink is declared even after undefining macros. */
> +#undef HAVE_RAW_DECL_SYMLINK
> +
> +/* Define to 1 if symlinkat is declared even after undefining macros. */
> +#undef HAVE_RAW_DECL_SYMLINKAT
> +
> /* Define to 1 if towctrans is declared even after undefining macros. */
> #undef HAVE_RAW_DECL_TOWCTRANS
>
> +/* Define to 1 if ttyname_r is declared even after undefining macros. */
> +#undef HAVE_RAW_DECL_TTYNAME_R
> +
> +/* Define to 1 if unlink is declared even after undefining macros. */
> +#undef HAVE_RAW_DECL_UNLINK
> +
> +/* Define to 1 if unlinkat is declared even after undefining macros. */
> +#undef HAVE_RAW_DECL_UNLINKAT
> +
> +/* Define to 1 if unlockpt is declared even after undefining macros. */
> +#undef HAVE_RAW_DECL_UNLOCKPT
> +
> +/* Define to 1 if unsetenv is declared even after undefining macros. */
> +#undef HAVE_RAW_DECL_UNSETENV
> +
> +/* Define to 1 if usleep is declared even after undefining macros. */
> +#undef HAVE_RAW_DECL_USLEEP
> +
> +/* Define to 1 if utimensat is declared even after undefining macros. */
> +#undef HAVE_RAW_DECL_UTIMENSAT
> +
> /* Define to 1 if wcpcpy is declared even after undefining macros. */
> #undef HAVE_RAW_DECL_WCPCPY
>
> @@ -330,6 +605,9 @@
> /* Define to 1 if wmemset is declared even after undefining macros. */
> #undef HAVE_RAW_DECL_WMEMSET
>
> +/* Define to 1 if _Exit is declared even after undefining macros. */
> +#undef HAVE_RAW_DECL__EXIT
> +
> /* Define to 1 if 'sig_atomic_t' is a signed integer type. */
> #undef HAVE_SIGNED_SIG_ATOMIC_T
>
> @@ -366,6 +644,9 @@
> /* Define to 1 if you have the <sys/stat.h> header file. */
> #undef HAVE_SYS_STAT_H
>
> +/* Define to 1 if you have the <sys/time.h> header file. */
> +#undef HAVE_SYS_TIME_H
> +
> /* Define to 1 if you have the <sys/types.h> header file. */
> #undef HAVE_SYS_TYPES_H
>
next prev parent reply other threads:[~2013-03-19 16:24 UTC|newest]
Thread overview: 51+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-03-15 2:02 New ARI warning Fri Mar 15 02:02:12 UTC 2013 in -D 2013-03-15-gmt GDB Administrator
2013-03-15 9:05 ` Yao Qi
2013-03-15 9:48 ` Compilation failure for mingw64 target (was New ARI warning Fri Mar 15 02:02:12 UTC 2013 in -D 2013-03-15-gmt) Pierre Muller
2013-03-15 11:06 ` Yao Qi
2013-03-15 11:24 ` Pierre Muller
2013-03-15 14:05 ` Yao Qi
2013-03-15 14:43 ` Yao Qi
2013-03-15 16:52 ` Tom Tromey
2013-03-15 16:55 ` Pierre Muller
[not found] ` <20313.4872871034$1363366373@news.gmane.org>
2013-03-15 17:01 ` Tom Tromey
2013-03-15 18:22 ` Eli Zaretskii
2013-03-15 18:24 ` Tom Tromey
2013-03-15 18:33 ` Eli Zaretskii
2013-03-15 18:53 ` Mike Frysinger
2013-03-15 18:58 ` Eli Zaretskii
2013-03-15 19:45 ` Mike Frysinger
2013-03-16 4:23 ` [PATCH 0/3] Fix build failure caused by ctf.c Yao Qi
2013-03-16 4:23 ` [PATCH 2/3] Write CTF in host byte order Yao Qi
2013-03-19 21:26 ` Joel Brobecker
2013-03-20 3:48 ` Yao Qi
2013-03-16 4:23 ` [PATCH 3/3] Don't use unportable macros Yao Qi
2013-03-19 17:12 ` Doug Evans
2013-03-20 2:48 ` Yao Qi
2013-03-20 15:17 ` Doug Evans
2013-03-21 1:58 ` Yao Qi
2013-03-20 17:36 ` Eli Zaretskii
2013-03-20 17:40 ` Tom Tromey
2013-03-25 4:08 ` [MinGW-w64]Build gdb/ctf.c failed asmwarrior
2013-03-25 6:41 ` asmwarrior
2013-03-25 8:28 ` Yao Qi
2013-03-25 8:39 ` Eli Zaretskii
2013-03-25 8:40 ` Eli Zaretskii
2013-03-25 9:15 ` Kai Tietz
2013-03-25 9:42 ` Yao Qi
2013-03-25 10:12 ` Kai Tietz
2013-03-25 12:43 ` Eli Zaretskii
2013-03-25 14:40 ` Yao Qi
2013-03-25 9:54 ` Eli Zaretskii
2013-03-25 10:50 ` Kai Tietz
2013-03-25 13:12 ` Eli Zaretskii
2013-03-25 13:21 ` Kai Tietz
2013-03-25 14:25 ` Eli Zaretskii
2013-03-25 15:18 ` Kai Tietz
2013-03-25 15:44 ` Eli Zaretskii
2013-03-25 16:14 ` Kai Tietz
2013-03-25 16:25 ` Eli Zaretskii
2013-03-16 7:35 ` [PATCH 1/3] Import mkdir module Yao Qi
2013-03-19 16:32 ` Doug Evans [this message]
2013-03-19 17:20 ` Eli Zaretskii
2013-03-19 21:23 ` Joel Brobecker
2013-03-15 16:22 ` New ARI warning Fri Mar 15 02:02:12 UTC 2013 in -D 2013-03-15-gmt Pedro Alves
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CADPb22Rvf6Ky4N_p8ELQy=wJ=+YN2Yf7qe+Te3H_=cFB45Pk-w@mail.gmail.com' \
--to=dje@google.com \
--cc=gdb-patches@sourceware.org \
--cc=yao@codesourcery.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox