Mirror of the gdb-patches mailing list
 help / color / mirror / Atom feed
From: Joel Brobecker <brobecker@adacore.com>
To: Doug Evans <dje@google.com>
Cc: Yao Qi <yao@codesourcery.com>, gdb-patches <gdb-patches@sourceware.org>
Subject: Re: [PATCH 1/3] Import mkdir module
Date: Tue, 19 Mar 2013 21:23:00 -0000	[thread overview]
Message-ID: <20130319205921.GB4506@adacore.com> (raw)
In-Reply-To: <CADPb22Rvf6Ky4N_p8ELQy=wJ=+YN2Yf7qe+Te3H_=cFB45Pk-w@mail.gmail.com>

> > 1. Check out my gulib repository to
> > 8d5bd1402003bd0153984b138735adf537d960b0, which is required by
> > update-gnulib.sh, so that we just import mkdir module instead
> > of upgrading gnulib we are using.
> > 2. Modify update-gnulib.sh to add mkdir.
> > 3. bash update-gnulib.sh <my gnulib repository>
> >
> > Build GDB with all-targets enabled and cross compile GDB for mingw32
> > target.
> 
> Hi.
> A ton of random stuff got dragged in.
> Is this typical of gnulib?
> 
> Including, but not limited to, the following.
> 
> If all this extra stuff is just due to updating to a newer version of
> gnulib, please separate out the update from the addition of mkdir.

Looking at the SHA1 and the update procedure, Yao used the correct
version of gnulib, and the extra stuff are dependencies. This is
typical of gnlib, and OK. I see where Eli is coming from when
he proposes implementing it locally rather than dependening on
gnulib, but I do feel like it's better to take advantage of gnulib
for portability issues. So I have a preference for gnulib, but
I will not object to a local implementation instead.

-- 
Joel


  parent reply	other threads:[~2013-03-19 21:18 UTC|newest]

Thread overview: 51+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2013-03-15  2:02 New ARI warning Fri Mar 15 02:02:12 UTC 2013 in -D 2013-03-15-gmt GDB Administrator
2013-03-15  9:05 ` Yao Qi
2013-03-15  9:48   ` Compilation failure for mingw64 target (was New ARI warning Fri Mar 15 02:02:12 UTC 2013 in -D 2013-03-15-gmt) Pierre Muller
2013-03-15 11:06     ` Yao Qi
2013-03-15 11:24       ` Pierre Muller
2013-03-15 14:05       ` Yao Qi
2013-03-15 14:43       ` Yao Qi
2013-03-15 16:52         ` Tom Tromey
2013-03-15 16:55           ` Pierre Muller
     [not found]           ` <20313.4872871034$1363366373@news.gmane.org>
2013-03-15 17:01             ` Tom Tromey
2013-03-15 18:22               ` Eli Zaretskii
2013-03-15 18:24                 ` Tom Tromey
2013-03-15 18:33                   ` Eli Zaretskii
2013-03-15 18:53                     ` Mike Frysinger
2013-03-15 18:58                       ` Eli Zaretskii
2013-03-15 19:45                         ` Mike Frysinger
2013-03-16  4:23                     ` [PATCH 0/3] Fix build failure caused by ctf.c Yao Qi
2013-03-16  4:23                       ` [PATCH 3/3] Don't use unportable macros Yao Qi
2013-03-19 17:12                         ` Doug Evans
2013-03-20  2:48                           ` Yao Qi
2013-03-20 15:17                             ` Doug Evans
2013-03-21  1:58                               ` Yao Qi
2013-03-20 17:36                             ` Eli Zaretskii
2013-03-20 17:40                               ` Tom Tromey
2013-03-25  4:08                                 ` [MinGW-w64]Build gdb/ctf.c failed asmwarrior
2013-03-25  6:41                                   ` asmwarrior
2013-03-25  8:28                                   ` Yao Qi
2013-03-25  8:39                                     ` Eli Zaretskii
2013-03-25  8:40                                   ` Eli Zaretskii
2013-03-25  9:15                                     ` Kai Tietz
2013-03-25  9:42                                       ` Yao Qi
2013-03-25 10:12                                         ` Kai Tietz
2013-03-25 12:43                                         ` Eli Zaretskii
2013-03-25 14:40                                           ` Yao Qi
2013-03-25  9:54                                       ` Eli Zaretskii
2013-03-25 10:50                                         ` Kai Tietz
2013-03-25 13:12                                           ` Eli Zaretskii
2013-03-25 13:21                                             ` Kai Tietz
2013-03-25 14:25                                               ` Eli Zaretskii
2013-03-25 15:18                                                 ` Kai Tietz
2013-03-25 15:44                                                   ` Eli Zaretskii
2013-03-25 16:14                                                     ` Kai Tietz
2013-03-25 16:25                                                       ` Eli Zaretskii
2013-03-16  4:23                       ` [PATCH 2/3] Write CTF in host byte order Yao Qi
2013-03-19 21:26                         ` Joel Brobecker
2013-03-20  3:48                           ` Yao Qi
2013-03-16  7:35                       ` [PATCH 1/3] Import mkdir module Yao Qi
2013-03-19 16:32                         ` Doug Evans
2013-03-19 17:20                           ` Eli Zaretskii
2013-03-19 21:23                           ` Joel Brobecker [this message]
2013-03-15 16:22   ` New ARI warning Fri Mar 15 02:02:12 UTC 2013 in -D 2013-03-15-gmt Pedro Alves

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20130319205921.GB4506@adacore.com \
    --to=brobecker@adacore.com \
    --cc=dje@google.com \
    --cc=gdb-patches@sourceware.org \
    --cc=yao@codesourcery.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox