Mirror of the gdb-patches mailing list
 help / color / mirror / Atom feed
From: Tom Tromey <tromey@redhat.com>
To: Yao Qi <yao@codesourcery.com>
Cc: Pierre Muller <pierre.muller@ics-cnrs.unistra.fr>,
	       <gdb-patches@sourceware.org>
Subject: Re: Compilation failure for mingw64 target (was New ARI warning Fri Mar 15 02:02:12 UTC 2013 in -D 2013-03-15-gmt)
Date: Fri, 15 Mar 2013 16:52:00 -0000	[thread overview]
Message-ID: <878v5o1un6.fsf@fleche.redhat.com> (raw)
In-Reply-To: <5143335C.2010902@codesourcery.com> (Yao Qi's message of "Fri, 15	Mar 2013 22:42:36 +0800")

>>>>> "Yao" == Yao Qi <yao@codesourcery.com> writes:

Yao> Here is the updated one, in which 'WORDS_BIGENDIAN' is checked to get
Yao> the host-endianness.  This macro is used somewhere else in GDB, so looks
Yao> it is a right way.

This part is ok.

Yao>    /* Create DIRNAME.  */
Yao> -  if (mkdir (dirname, S_IRWXU | S_IRGRP | S_IXGRP | S_IROTH | S_IXOTH)
Yao> -      && errno != EEXIST)
Yao> +#ifdef USE_WIN32API
Yao> +  ret = mkdir (dirname);
Yao> +#else
Yao> +  ret = mkdir (dirname, S_IRUSR | S_IWUSR | S_IXUSR);
Yao> +#endif

I think S_IRUSR, S_IWUSR,and S_IXUSR are generally ok.
At least, I see them unprotected in remote-fileio.c.
So I think a simpler patch here would suffice, and would be cleaner
besides.

thanks,
Tom


  reply	other threads:[~2013-03-15 16:43 UTC|newest]

Thread overview: 51+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2013-03-15  2:02 New ARI warning Fri Mar 15 02:02:12 UTC 2013 in -D 2013-03-15-gmt GDB Administrator
2013-03-15  9:05 ` Yao Qi
2013-03-15  9:48   ` Compilation failure for mingw64 target (was New ARI warning Fri Mar 15 02:02:12 UTC 2013 in -D 2013-03-15-gmt) Pierre Muller
2013-03-15 11:06     ` Yao Qi
2013-03-15 11:24       ` Pierre Muller
2013-03-15 14:05       ` Yao Qi
2013-03-15 14:43       ` Yao Qi
2013-03-15 16:52         ` Tom Tromey [this message]
2013-03-15 16:55           ` Pierre Muller
     [not found]           ` <20313.4872871034$1363366373@news.gmane.org>
2013-03-15 17:01             ` Tom Tromey
2013-03-15 18:22               ` Eli Zaretskii
2013-03-15 18:24                 ` Tom Tromey
2013-03-15 18:33                   ` Eli Zaretskii
2013-03-15 18:53                     ` Mike Frysinger
2013-03-15 18:58                       ` Eli Zaretskii
2013-03-15 19:45                         ` Mike Frysinger
2013-03-16  4:23                     ` [PATCH 0/3] Fix build failure caused by ctf.c Yao Qi
2013-03-16  4:23                       ` [PATCH 3/3] Don't use unportable macros Yao Qi
2013-03-19 17:12                         ` Doug Evans
2013-03-20  2:48                           ` Yao Qi
2013-03-20 15:17                             ` Doug Evans
2013-03-21  1:58                               ` Yao Qi
2013-03-20 17:36                             ` Eli Zaretskii
2013-03-20 17:40                               ` Tom Tromey
2013-03-25  4:08                                 ` [MinGW-w64]Build gdb/ctf.c failed asmwarrior
2013-03-25  6:41                                   ` asmwarrior
2013-03-25  8:28                                   ` Yao Qi
2013-03-25  8:39                                     ` Eli Zaretskii
2013-03-25  8:40                                   ` Eli Zaretskii
2013-03-25  9:15                                     ` Kai Tietz
2013-03-25  9:42                                       ` Yao Qi
2013-03-25 10:12                                         ` Kai Tietz
2013-03-25 12:43                                         ` Eli Zaretskii
2013-03-25 14:40                                           ` Yao Qi
2013-03-25  9:54                                       ` Eli Zaretskii
2013-03-25 10:50                                         ` Kai Tietz
2013-03-25 13:12                                           ` Eli Zaretskii
2013-03-25 13:21                                             ` Kai Tietz
2013-03-25 14:25                                               ` Eli Zaretskii
2013-03-25 15:18                                                 ` Kai Tietz
2013-03-25 15:44                                                   ` Eli Zaretskii
2013-03-25 16:14                                                     ` Kai Tietz
2013-03-25 16:25                                                       ` Eli Zaretskii
2013-03-16  4:23                       ` [PATCH 2/3] Write CTF in host byte order Yao Qi
2013-03-19 21:26                         ` Joel Brobecker
2013-03-20  3:48                           ` Yao Qi
2013-03-16  7:35                       ` [PATCH 1/3] Import mkdir module Yao Qi
2013-03-19 16:32                         ` Doug Evans
2013-03-19 17:20                           ` Eli Zaretskii
2013-03-19 21:23                           ` Joel Brobecker
2013-03-15 16:22   ` New ARI warning Fri Mar 15 02:02:12 UTC 2013 in -D 2013-03-15-gmt Pedro Alves

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=878v5o1un6.fsf@fleche.redhat.com \
    --to=tromey@redhat.com \
    --cc=gdb-patches@sourceware.org \
    --cc=pierre.muller@ics-cnrs.unistra.fr \
    --cc=yao@codesourcery.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox