From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <gdb-patches-return-99598-listarch-gdb-patches=sources.redhat.com@sourceware.org>
Received: (qmail 32620 invoked by alias); 15 Mar 2013 16:43:28 -0000
Received: (qmail 32426 invoked by uid 22791); 15 Mar 2013 16:43:25 -0000
X-SWARE-Spam-Status: No, hits=-7.6 required=5.0	tests=AWL,BAYES_00,KHOP_RCVD_UNTRUST,KHOP_SPAMHAUS_DROP,RCVD_IN_DNSWL_HI,RCVD_IN_HOSTKARMA_W,RP_MATCHES_RCVD,SPF_HELO_PASS
X-Spam-Check-By: sourceware.org
Received: from mx1.redhat.com (HELO mx1.redhat.com) (209.132.183.28)    by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Fri, 15 Mar 2013 16:43:16 +0000
Received: from int-mx09.intmail.prod.int.phx2.redhat.com (int-mx09.intmail.prod.int.phx2.redhat.com [10.5.11.22])	by mx1.redhat.com (8.14.4/8.14.4) with ESMTP id r2FGhC6x029467	(version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=OK);	Fri, 15 Mar 2013 12:43:12 -0400
Received: from barimba (ovpn01.gateway.prod.ext.phx2.redhat.com [10.5.9.1])	by int-mx09.intmail.prod.int.phx2.redhat.com (8.14.4/8.14.4) with ESMTP id r2FGh9I8011099	(version=TLSv1/SSLv3 cipher=DHE-RSA-AES128-SHA bits=128 verify=NO);	Fri, 15 Mar 2013 12:43:10 -0400
From: Tom Tromey <tromey@redhat.com>
To: Yao Qi <yao@codesourcery.com>
Cc: Pierre Muller <pierre.muller@ics-cnrs.unistra.fr>,        <gdb-patches@sourceware.org>
Subject: Re: Compilation failure for mingw64 target (was New ARI warning Fri Mar 15 02:02:12 UTC 2013 in -D 2013-03-15-gmt)
References: <20130315020212.GA23545@sourceware.org>	<5142E409.5090109@codesourcery.com>	<002901ce2162$414d7530$c3e85f90$@muller@ics-cnrs.unistra.fr>	<51430063.2060007@codesourcery.com>	<5143335C.2010902@codesourcery.com>
Date: Fri, 15 Mar 2013 16:52:00 -0000
In-Reply-To: <5143335C.2010902@codesourcery.com> (Yao Qi's message of "Fri, 15	Mar 2013 22:42:36 +0800")
Message-ID: <878v5o1un6.fsf@fleche.redhat.com>
User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/24.3 (gnu/linux)
MIME-Version: 1.0
Content-Type: text/plain
Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm
Precedence: bulk
List-Id: <gdb-patches.sourceware.org>
List-Subscribe: <mailto:gdb-patches-subscribe@sourceware.org>
List-Archive: <http://sourceware.org/ml/gdb-patches/>
List-Post: <mailto:gdb-patches@sourceware.org>
List-Help: <mailto:gdb-patches-help@sourceware.org>, <http://sourceware.org/ml/#faqs>
Sender: gdb-patches-owner@sourceware.org
X-SW-Source: 2013-03/txt/msg00674.txt.bz2

>>>>> "Yao" == Yao Qi <yao@codesourcery.com> writes:

Yao> Here is the updated one, in which 'WORDS_BIGENDIAN' is checked to get
Yao> the host-endianness.  This macro is used somewhere else in GDB, so looks
Yao> it is a right way.

This part is ok.

Yao>    /* Create DIRNAME.  */
Yao> -  if (mkdir (dirname, S_IRWXU | S_IRGRP | S_IXGRP | S_IROTH | S_IXOTH)
Yao> -      && errno != EEXIST)
Yao> +#ifdef USE_WIN32API
Yao> +  ret = mkdir (dirname);
Yao> +#else
Yao> +  ret = mkdir (dirname, S_IRUSR | S_IWUSR | S_IXUSR);
Yao> +#endif

I think S_IRUSR, S_IWUSR,and S_IXUSR are generally ok.
At least, I see them unprotected in remote-fileio.c.
So I think a simpler patch here would suffice, and would be cleaner
besides.

thanks,
Tom