From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 16051 invoked by alias); 19 Mar 2013 21:18:15 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 16024 invoked by uid 89); 19 Mar 2013 21:18:07 -0000 X-Spam-Sware-Status: No, score=-1.9 required=5.0 tests=AWL,BAYES_00 autolearn=ham version=3.3.1 Received: from rock.gnat.com (HELO rock.gnat.com) (205.232.38.15) by sourceware.org (qpsmtpd/0.84/v0.84-167-ge50287c) with ESMTP; Tue, 19 Mar 2013 21:18:04 +0000 Received: from localhost (localhost.localdomain [127.0.0.1]) by filtered-rock.gnat.com (Postfix) with ESMTP id 3F67C2E9CA; Tue, 19 Mar 2013 16:59:23 -0400 (EDT) Received: from rock.gnat.com ([127.0.0.1]) by localhost (rock.gnat.com [127.0.0.1]) (amavisd-new, port 10024) with LMTP id 39F1gRO1G6ea; Tue, 19 Mar 2013 16:59:23 -0400 (EDT) Received: from joel.gnat.com (localhost.localdomain [127.0.0.1]) by rock.gnat.com (Postfix) with ESMTP id 037612E646; Tue, 19 Mar 2013 16:59:22 -0400 (EDT) Received: by joel.gnat.com (Postfix, from userid 1000) id 2C39BC25A3; Tue, 19 Mar 2013 13:59:21 -0700 (PDT) Date: Tue, 19 Mar 2013 21:23:00 -0000 From: Joel Brobecker To: Doug Evans Cc: Yao Qi , gdb-patches Subject: Re: [PATCH 1/3] Import mkdir module Message-ID: <20130319205921.GB4506@adacore.com> References: <83ip4s4ixc.fsf@gnu.org> <1363407692-18959-1-git-send-email-yao@codesourcery.com> <1363407692-18959-2-git-send-email-yao@codesourcery.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.5.21 (2010-09-15) X-SW-Source: 2013-03/txt/msg00721.txt.bz2 > > 1. Check out my gulib repository to > > 8d5bd1402003bd0153984b138735adf537d960b0, which is required by > > update-gnulib.sh, so that we just import mkdir module instead > > of upgrading gnulib we are using. > > 2. Modify update-gnulib.sh to add mkdir. > > 3. bash update-gnulib.sh > > > > Build GDB with all-targets enabled and cross compile GDB for mingw32 > > target. > > Hi. > A ton of random stuff got dragged in. > Is this typical of gnulib? > > Including, but not limited to, the following. > > If all this extra stuff is just due to updating to a newer version of > gnulib, please separate out the update from the addition of mkdir. Looking at the SHA1 and the update procedure, Yao used the correct version of gnulib, and the extra stuff are dependencies. This is typical of gnlib, and OK. I see where Eli is coming from when he proposes implementing it locally rather than dependening on gnulib, but I do feel like it's better to take advantage of gnulib for portability issues. So I have a preference for gnulib, but I will not object to a local implementation instead. -- Joel