From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 17483 invoked by alias); 19 Mar 2013 16:24:39 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 17464 invoked by uid 89); 19 Mar 2013 16:24:31 -0000 X-Spam-Sware-Status: No, score=-3.7 required=5.0 tests=AWL,BAYES_00,DKIM_ADSP_CUSTOM_MED,DKIM_SIGNED,NML_ADSP_CUSTOM_MED,RCVD_IN_DNSWL_LOW,RP_MATCHES_RCVD,TW_CP,TW_MK,TW_TD,TW_TR,T_DKIM_INVALID autolearn=ham version=3.3.1 Received: from mail-ve0-f170.google.com (HELO mail-ve0-f170.google.com) (209.85.128.170) by sourceware.org (qpsmtpd/0.84/v0.84-167-ge50287c) with ESMTP; Tue, 19 Mar 2013 16:24:27 +0000 Received: by mail-ve0-f170.google.com with SMTP id 14so575273vea.15 for ; Tue, 19 Mar 2013 09:24:25 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20120113; h=mime-version:x-received:in-reply-to:references:date:message-id :subject:from:to:cc:content-type:x-gm-message-state; bh=Nix/aJOyOzYpRNTQSv+N4tc6YZajJr8eK2EO6uJtNlI=; b=ouHftzLr4OVbo+CeYINzTwkpDHZmnvaxcDK450x832xBnngLRItTRg0FOHXHD5fG2x vhn25wgv2eSC3T4+SUFjOLucpNHe9XLSwGwauyhaiRo0nkJ/zh98v7NbEA2+JZ4PtcdL Vd/ggquJKD/9tib8hCPAeViHbOi52lXK5SoQQhanFtuQy4TLOVu1vin4gzzcxAcJQvBE VWlGTZJVHCPGU70NO8VZFK2hH22yPrf7HS4RYfZBUFP0iIpKX5HRNqDEMacGsn1LR/An GpCIrq2bmV42/fp3B6W9tD71E8TZfDD6NuKZHELvAjcxcTksSviIF08S0L6Q336P5HPU 7ZHw== MIME-Version: 1.0 X-Received: by 10.52.74.102 with SMTP id s6mr2814379vdv.28.1363710265506; Tue, 19 Mar 2013 09:24:25 -0700 (PDT) Received: by 10.220.168.143 with HTTP; Tue, 19 Mar 2013 09:24:25 -0700 (PDT) In-Reply-To: <1363407692-18959-2-git-send-email-yao@codesourcery.com> References: <83ip4s4ixc.fsf@gnu.org> <1363407692-18959-1-git-send-email-yao@codesourcery.com> <1363407692-18959-2-git-send-email-yao@codesourcery.com> Date: Tue, 19 Mar 2013 16:32:00 -0000 Message-ID: Subject: Re: [PATCH 1/3] Import mkdir module From: Doug Evans To: Yao Qi Cc: gdb-patches Content-Type: text/plain; charset=ISO-8859-1 X-Gm-Message-State: ALoCoQmJ8YUtBfKC+fKoqKWsoq5oGlAgxkYm8Lr8VKXNczYrIvJy7uHOHYBIAQNUsL/hCXCX6K24e6qv9oYkuigCJb+hvTDx6TT0ka9P9YsOGuNm3sv8yusxATuedUHqAHKjDt+EStqfCvbynF1ZYsI5ixepHS4Bz9T4nhCZGoB4inLiHMUGyA9KaL/NQsU58yv/N0fOqP4anPTxjF88Nqelj23OjKhBbQ== X-SW-Source: 2013-03/txt/msg00715.txt.bz2 On Fri, Mar 15, 2013 at 9:21 PM, Yao Qi wrote: > Here are my steps to import mkdir module into GDB gnulib. > > 1. Check out my gulib repository to > 8d5bd1402003bd0153984b138735adf537d960b0, which is required by > update-gnulib.sh, so that we just import mkdir module instead > of upgrading gnulib we are using. > 2. Modify update-gnulib.sh to add mkdir. > 3. bash update-gnulib.sh > > Build GDB with all-targets enabled and cross compile GDB for mingw32 > target. Hi. A ton of random stuff got dragged in. Is this typical of gnulib? Including, but not limited to, the following. If all this extra stuff is just due to updating to a newer version of gnulib, please separate out the update from the addition of mkdir. > > +/* Define to 1 if canonicalize_file_name is declared even after undefining > + macros. */ > +#undef HAVE_RAW_DECL_CANONICALIZE_FILE_NAME > + > +/* Define to 1 if chdir is declared even after undefining macros. */ > +#undef HAVE_RAW_DECL_CHDIR > + > +/* Define to 1 if chown is declared even after undefining macros. */ > +#undef HAVE_RAW_DECL_CHOWN > + > +/* Define to 1 if dup is declared even after undefining macros. */ > +#undef HAVE_RAW_DECL_DUP > + > +/* Define to 1 if dup2 is declared even after undefining macros. */ > +#undef HAVE_RAW_DECL_DUP2 > + > +/* Define to 1 if dup3 is declared even after undefining macros. */ > +#undef HAVE_RAW_DECL_DUP3 > + > +/* Define to 1 if endusershell is declared even after undefining macros. */ > +#undef HAVE_RAW_DECL_ENDUSERSHELL > + > +/* Define to 1 if environ is declared even after undefining macros. */ > +#undef HAVE_RAW_DECL_ENVIRON > + > +/* Define to 1 if euidaccess is declared even after undefining macros. */ > +#undef HAVE_RAW_DECL_EUIDACCESS > + > +/* Define to 1 if faccessat is declared even after undefining macros. */ > +#undef HAVE_RAW_DECL_FACCESSAT > + > +/* Define to 1 if fchdir is declared even after undefining macros. */ > +#undef HAVE_RAW_DECL_FCHDIR > + > +/* Define to 1 if fchmodat is declared even after undefining macros. */ > +#undef HAVE_RAW_DECL_FCHMODAT > + > +/* Define to 1 if fchownat is declared even after undefining macros. */ > +#undef HAVE_RAW_DECL_FCHOWNAT > + > +/* Define to 1 if fdatasync is declared even after undefining macros. */ > +#undef HAVE_RAW_DECL_FDATASYNC > + > /* Define to 1 if ffsl is declared even after undefining macros. */ > #undef HAVE_RAW_DECL_FFSL > > /* Define to 1 if ffsll is declared even after undefining macros. */ > #undef HAVE_RAW_DECL_FFSLL > > +/* Define to 1 if fstat is declared even after undefining macros. */ > +#undef HAVE_RAW_DECL_FSTAT > + > +/* Define to 1 if fstatat is declared even after undefining macros. */ > +#undef HAVE_RAW_DECL_FSTATAT > + > +/* Define to 1 if fsync is declared even after undefining macros. */ > +#undef HAVE_RAW_DECL_FSYNC > + > +/* Define to 1 if ftruncate is declared even after undefining macros. */ > +#undef HAVE_RAW_DECL_FTRUNCATE > + > +/* Define to 1 if futimens is declared even after undefining macros. */ > +#undef HAVE_RAW_DECL_FUTIMENS > + > +/* Define to 1 if getcwd is declared even after undefining macros. */ > +#undef HAVE_RAW_DECL_GETCWD > + > +/* Define to 1 if getdomainname is declared even after undefining macros. */ > +#undef HAVE_RAW_DECL_GETDOMAINNAME > + > +/* Define to 1 if getdtablesize is declared even after undefining macros. */ > +#undef HAVE_RAW_DECL_GETDTABLESIZE > + > +/* Define to 1 if getgroups is declared even after undefining macros. */ > +#undef HAVE_RAW_DECL_GETGROUPS > + > +/* Define to 1 if gethostname is declared even after undefining macros. */ > +#undef HAVE_RAW_DECL_GETHOSTNAME > + > +/* Define to 1 if getloadavg is declared even after undefining macros. */ > +#undef HAVE_RAW_DECL_GETLOADAVG > + > +/* Define to 1 if getlogin is declared even after undefining macros. */ > +#undef HAVE_RAW_DECL_GETLOGIN > + > +/* Define to 1 if getlogin_r is declared even after undefining macros. */ > +#undef HAVE_RAW_DECL_GETLOGIN_R > + > +/* Define to 1 if getpagesize is declared even after undefining macros. */ > +#undef HAVE_RAW_DECL_GETPAGESIZE > + > +/* Define to 1 if getsubopt is declared even after undefining macros. */ > +#undef HAVE_RAW_DECL_GETSUBOPT > + > +/* Define to 1 if getusershell is declared even after undefining macros. */ > +#undef HAVE_RAW_DECL_GETUSERSHELL > + > +/* Define to 1 if grantpt is declared even after undefining macros. */ > +#undef HAVE_RAW_DECL_GRANTPT > + > +/* Define to 1 if group_member is declared even after undefining macros. */ > +#undef HAVE_RAW_DECL_GROUP_MEMBER > + > /* Define to 1 if imaxabs is declared even after undefining macros. */ > #undef HAVE_RAW_DECL_IMAXABS > > /* Define to 1 if imaxdiv is declared even after undefining macros. */ > #undef HAVE_RAW_DECL_IMAXDIV > > +/* Define to 1 if initstate is declared even after undefining macros. */ > +#undef HAVE_RAW_DECL_INITSTATE > + > +/* Define to 1 if initstate_r is declared even after undefining macros. */ > +#undef HAVE_RAW_DECL_INITSTATE_R > + > +/* Define to 1 if isatty is declared even after undefining macros. */ > +#undef HAVE_RAW_DECL_ISATTY > + > /* Define to 1 if iswctype is declared even after undefining macros. */ > #undef HAVE_RAW_DECL_ISWCTYPE > > +/* Define to 1 if lchmod is declared even after undefining macros. */ > +#undef HAVE_RAW_DECL_LCHMOD > + > +/* Define to 1 if lchown is declared even after undefining macros. */ > +#undef HAVE_RAW_DECL_LCHOWN > + > +/* Define to 1 if link is declared even after undefining macros. */ > +#undef HAVE_RAW_DECL_LINK > + > +/* Define to 1 if linkat is declared even after undefining macros. */ > +#undef HAVE_RAW_DECL_LINKAT > + > +/* Define to 1 if lseek is declared even after undefining macros. */ > +#undef HAVE_RAW_DECL_LSEEK > + > +/* Define to 1 if lstat is declared even after undefining macros. */ > +#undef HAVE_RAW_DECL_LSTAT > + > /* Define to 1 if mbrlen is declared even after undefining macros. */ > #undef HAVE_RAW_DECL_MBRLEN > > @@ -171,9 +311,108 @@ > /* Define to 1 if memrchr is declared even after undefining macros. */ > #undef HAVE_RAW_DECL_MEMRCHR > > +/* Define to 1 if mkdirat is declared even after undefining macros. */ > +#undef HAVE_RAW_DECL_MKDIRAT > + > +/* Define to 1 if mkdtemp is declared even after undefining macros. */ > +#undef HAVE_RAW_DECL_MKDTEMP > + > +/* Define to 1 if mkfifo is declared even after undefining macros. */ > +#undef HAVE_RAW_DECL_MKFIFO > + > +/* Define to 1 if mkfifoat is declared even after undefining macros. */ > +#undef HAVE_RAW_DECL_MKFIFOAT > + > +/* Define to 1 if mknod is declared even after undefining macros. */ > +#undef HAVE_RAW_DECL_MKNOD > + > +/* Define to 1 if mknodat is declared even after undefining macros. */ > +#undef HAVE_RAW_DECL_MKNODAT > + > +/* Define to 1 if mkostemp is declared even after undefining macros. */ > +#undef HAVE_RAW_DECL_MKOSTEMP > + > +/* Define to 1 if mkostemps is declared even after undefining macros. */ > +#undef HAVE_RAW_DECL_MKOSTEMPS > + > +/* Define to 1 if mkstemp is declared even after undefining macros. */ > +#undef HAVE_RAW_DECL_MKSTEMP > + > +/* Define to 1 if mkstemps is declared even after undefining macros. */ > +#undef HAVE_RAW_DECL_MKSTEMPS > + > +/* Define to 1 if pipe is declared even after undefining macros. */ > +#undef HAVE_RAW_DECL_PIPE > + > +/* Define to 1 if pipe2 is declared even after undefining macros. */ > +#undef HAVE_RAW_DECL_PIPE2 > + > +/* Define to 1 if posix_openpt is declared even after undefining macros. */ > +#undef HAVE_RAW_DECL_POSIX_OPENPT > + > +/* Define to 1 if pread is declared even after undefining macros. */ > +#undef HAVE_RAW_DECL_PREAD > + > +/* Define to 1 if ptsname is declared even after undefining macros. */ > +#undef HAVE_RAW_DECL_PTSNAME > + > +/* Define to 1 if ptsname_r is declared even after undefining macros. */ > +#undef HAVE_RAW_DECL_PTSNAME_R > + > +/* Define to 1 if pwrite is declared even after undefining macros. */ > +#undef HAVE_RAW_DECL_PWRITE > + > +/* Define to 1 if random is declared even after undefining macros. */ > +#undef HAVE_RAW_DECL_RANDOM > + > +/* Define to 1 if random_r is declared even after undefining macros. */ > +#undef HAVE_RAW_DECL_RANDOM_R > + > /* Define to 1 if rawmemchr is declared even after undefining macros. */ > #undef HAVE_RAW_DECL_RAWMEMCHR > > +/* Define to 1 if readlink is declared even after undefining macros. */ > +#undef HAVE_RAW_DECL_READLINK > + > +/* Define to 1 if readlinkat is declared even after undefining macros. */ > +#undef HAVE_RAW_DECL_READLINKAT > + > +/* Define to 1 if realpath is declared even after undefining macros. */ > +#undef HAVE_RAW_DECL_REALPATH > + > +/* Define to 1 if rmdir is declared even after undefining macros. */ > +#undef HAVE_RAW_DECL_RMDIR > + > +/* Define to 1 if rpmatch is declared even after undefining macros. */ > +#undef HAVE_RAW_DECL_RPMATCH > + > +/* Define to 1 if setenv is declared even after undefining macros. */ > +#undef HAVE_RAW_DECL_SETENV > + > +/* Define to 1 if sethostname is declared even after undefining macros. */ > +#undef HAVE_RAW_DECL_SETHOSTNAME > + > +/* Define to 1 if setstate is declared even after undefining macros. */ > +#undef HAVE_RAW_DECL_SETSTATE > + > +/* Define to 1 if setstate_r is declared even after undefining macros. */ > +#undef HAVE_RAW_DECL_SETSTATE_R > + > +/* Define to 1 if setusershell is declared even after undefining macros. */ > +#undef HAVE_RAW_DECL_SETUSERSHELL > + > +/* Define to 1 if sleep is declared even after undefining macros. */ > +#undef HAVE_RAW_DECL_SLEEP > + > +/* Define to 1 if srandom is declared even after undefining macros. */ > +#undef HAVE_RAW_DECL_SRANDOM > + > +/* Define to 1 if srandom_r is declared even after undefining macros. */ > +#undef HAVE_RAW_DECL_SRANDOM_R > + > +/* Define to 1 if stat is declared even after undefining macros. */ > +#undef HAVE_RAW_DECL_STAT > + > /* Define to 1 if stpcpy is declared even after undefining macros. */ > #undef HAVE_RAW_DECL_STPCPY > > @@ -210,21 +449,57 @@ > /* Define to 1 if strsignal is declared even after undefining macros. */ > #undef HAVE_RAW_DECL_STRSIGNAL > > +/* Define to 1 if strtod is declared even after undefining macros. */ > +#undef HAVE_RAW_DECL_STRTOD > + > /* Define to 1 if strtoimax is declared even after undefining macros. */ > #undef HAVE_RAW_DECL_STRTOIMAX > > /* Define to 1 if strtok_r is declared even after undefining macros. */ > #undef HAVE_RAW_DECL_STRTOK_R > > +/* Define to 1 if strtoll is declared even after undefining macros. */ > +#undef HAVE_RAW_DECL_STRTOLL > + > +/* Define to 1 if strtoull is declared even after undefining macros. */ > +#undef HAVE_RAW_DECL_STRTOULL > + > /* Define to 1 if strtoumax is declared even after undefining macros. */ > #undef HAVE_RAW_DECL_STRTOUMAX > > /* Define to 1 if strverscmp is declared even after undefining macros. */ > #undef HAVE_RAW_DECL_STRVERSCMP > > +/* Define to 1 if symlink is declared even after undefining macros. */ > +#undef HAVE_RAW_DECL_SYMLINK > + > +/* Define to 1 if symlinkat is declared even after undefining macros. */ > +#undef HAVE_RAW_DECL_SYMLINKAT > + > /* Define to 1 if towctrans is declared even after undefining macros. */ > #undef HAVE_RAW_DECL_TOWCTRANS > > +/* Define to 1 if ttyname_r is declared even after undefining macros. */ > +#undef HAVE_RAW_DECL_TTYNAME_R > + > +/* Define to 1 if unlink is declared even after undefining macros. */ > +#undef HAVE_RAW_DECL_UNLINK > + > +/* Define to 1 if unlinkat is declared even after undefining macros. */ > +#undef HAVE_RAW_DECL_UNLINKAT > + > +/* Define to 1 if unlockpt is declared even after undefining macros. */ > +#undef HAVE_RAW_DECL_UNLOCKPT > + > +/* Define to 1 if unsetenv is declared even after undefining macros. */ > +#undef HAVE_RAW_DECL_UNSETENV > + > +/* Define to 1 if usleep is declared even after undefining macros. */ > +#undef HAVE_RAW_DECL_USLEEP > + > +/* Define to 1 if utimensat is declared even after undefining macros. */ > +#undef HAVE_RAW_DECL_UTIMENSAT > + > /* Define to 1 if wcpcpy is declared even after undefining macros. */ > #undef HAVE_RAW_DECL_WCPCPY > > @@ -330,6 +605,9 @@ > /* Define to 1 if wmemset is declared even after undefining macros. */ > #undef HAVE_RAW_DECL_WMEMSET > > +/* Define to 1 if _Exit is declared even after undefining macros. */ > +#undef HAVE_RAW_DECL__EXIT > + > /* Define to 1 if 'sig_atomic_t' is a signed integer type. */ > #undef HAVE_SIGNED_SIG_ATOMIC_T > > @@ -366,6 +644,9 @@ > /* Define to 1 if you have the header file. */ > #undef HAVE_SYS_STAT_H > > +/* Define to 1 if you have the header file. */ > +#undef HAVE_SYS_TIME_H > + > /* Define to 1 if you have the header file. */ > #undef HAVE_SYS_TYPES_H >