Re: [PATCH 1/3] Remove spurious exceptions.h inclusions

[Doug Evans <dje@google.com>]

On Mon, Sep 1, 2014 at 11:42 AM, Gary Benson <gbenson@redhat.com> wrote:
> defs.h includes utils.h, and utils.h includes exceptions.h.  All GDB
> .c files include defs.h as their first line, so no file other than
> utils.h needs to include exceptions.h.  This commit removes all such
> inclusions.
>
> Doug, I Cc'd you on this one as you asked me to avoid giant mechanical
> ChangeLog entries but I couldn't figure out how I'd rewrite this one.

For reference sake,
I said that for two reasons:
1) to save you some typing
2) to keep the S/N ratio of the ChangeLog file from dropping, and in
this case from dropping significantly.  Yikes!

> gdb/ChangeLog:
>
>         * ada-lang.c: Do not include exceptions.h.
>         * ada-valprint.c: Likewise.
>         * amd64-tdep.c: Likewise.
> [...]

I realize one of the guidelines for changelogs is to document every
file that's changed, but if we can agree that "All callers updated."
can apply to all callers in all files, then I don't see why we
couldn't be ok with something like the following for this case:

        * All .c files: Do not include exceptions.h.

Yeah, it's not pedantically correct, not all .c files were touched.
But I can live with that given the alternative.