Mirror of the gdb-patches mailing list
 help / color / mirror / Atom feed
From: Pedro Alves <palves@redhat.com>
To: Gary Benson <gbenson@redhat.com>, Doug Evans <dje@google.com>
Cc: gdb-patches <gdb-patches@sourceware.org>
Subject: Re: [PATCH 1/3] Remove spurious exceptions.h inclusions
Date: Thu, 09 Oct 2014 11:43:00 -0000	[thread overview]
Message-ID: <543674E5.3070003@redhat.com> (raw)
In-Reply-To: <20141009094319.GA6910@blade.nx>

On 10/09/2014 10:43 AM, Gary Benson wrote:
> Doug Evans wrote:
>> Can you also update the Include files section of the coding standards?
>> https://sourceware.org/gdb/wiki/Internals%20GDB-C-Coding-Standards
>>
>> This section needs to list exceptions.h and others that .c and .h
>> files are no longer supposed to directly include.
> 
> I have updated it.  Rather than adding a long list of headers that
> will undoubtedly rot I have specified that files should not include
> stuff included by whichever of defs.h, server.h, common-defs.h is
> relevant.  The wording is not ideal but it's the best I could come
> up with.

Thanks Gary.  I've extended it a bit to mention the ".c file must include
its header" rule, which I think ends up clarifying it too.

Thanks,
Pedro Alves


  reply	other threads:[~2014-10-09 11:43 UTC|newest]

Thread overview: 17+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-09-01 15:42 [PATCH 0/3] Rationalize cleanups/exceptions includes Gary Benson
2014-09-01 15:42 ` [PATCH 3/3] Include common-exceptions.h in common-defs.h Gary Benson
2014-10-07 18:05   ` Pedro Alves
2014-09-01 15:42 ` [PATCH 2/3] Include cleanups.h " Gary Benson
2014-10-07 18:05   ` Pedro Alves
2014-09-01 15:42 ` [PATCH 1/3] Remove spurious exceptions.h inclusions Gary Benson
2014-10-07 18:04   ` Pedro Alves
2014-10-08 17:03   ` Doug Evans
2014-10-08 17:12     ` Doug Evans
2014-10-08 17:21       ` Pedro Alves
2014-10-08 17:24       ` Doug Evans
2014-10-09  9:43         ` Gary Benson
2014-10-09 11:43           ` Pedro Alves [this message]
2014-10-09  9:45     ` Gary Benson
2014-10-09 14:47       ` Doug Evans
2014-10-07  8:58 ` [PING PATCH 0/3] Rationalize cleanups/exceptions includes Gary Benson
2014-10-08  8:47 ` [PATCH " Gary Benson

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=543674E5.3070003@redhat.com \
    --to=palves@redhat.com \
    --cc=dje@google.com \
    --cc=gbenson@redhat.com \
    --cc=gdb-patches@sourceware.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox