From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 30990 invoked by alias); 9 Oct 2014 11:43:39 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 30980 invoked by uid 89); 9 Oct 2014 11:43:38 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-2.0 required=5.0 tests=AWL,BAYES_00,SPF_HELO_PASS,SPF_PASS,T_RP_MATCHES_RCVD autolearn=ham version=3.3.2 X-HELO: mx1.redhat.com Received: from mx1.redhat.com (HELO mx1.redhat.com) (209.132.183.28) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with (AES256-GCM-SHA384 encrypted) ESMTPS; Thu, 09 Oct 2014 11:43:37 +0000 Received: from int-mx11.intmail.prod.int.phx2.redhat.com (int-mx11.intmail.prod.int.phx2.redhat.com [10.5.11.24]) by mx1.redhat.com (8.14.4/8.14.4) with ESMTP id s99BhZEG022922 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-GCM-SHA384 bits=256 verify=FAIL); Thu, 9 Oct 2014 07:43:35 -0400 Received: from [127.0.0.1] (ovpn01.gateway.prod.ext.ams2.redhat.com [10.39.146.11]) by int-mx11.intmail.prod.int.phx2.redhat.com (8.14.4/8.14.4) with ESMTP id s99BhX2X027287; Thu, 9 Oct 2014 07:43:34 -0400 Message-ID: <543674E5.3070003@redhat.com> Date: Thu, 09 Oct 2014 11:43:00 -0000 From: Pedro Alves User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:31.0) Gecko/20100101 Thunderbird/31.1.1 MIME-Version: 1.0 To: Gary Benson , Doug Evans CC: gdb-patches Subject: Re: [PATCH 1/3] Remove spurious exceptions.h inclusions References: <1409586154-16196-1-git-send-email-gbenson@redhat.com> <1409586154-16196-2-git-send-email-gbenson@redhat.com> <20141009094319.GA6910@blade.nx> In-Reply-To: <20141009094319.GA6910@blade.nx> Content-Type: text/plain; charset=windows-1252 Content-Transfer-Encoding: 7bit X-SW-Source: 2014-10/txt/msg00199.txt.bz2 On 10/09/2014 10:43 AM, Gary Benson wrote: > Doug Evans wrote: >> Can you also update the Include files section of the coding standards? >> https://sourceware.org/gdb/wiki/Internals%20GDB-C-Coding-Standards >> >> This section needs to list exceptions.h and others that .c and .h >> files are no longer supposed to directly include. > > I have updated it. Rather than adding a long list of headers that > will undoubtedly rot I have specified that files should not include > stuff included by whichever of defs.h, server.h, common-defs.h is > relevant. The wording is not ideal but it's the best I could come > up with. Thanks Gary. I've extended it a bit to mention the ".c file must include its header" rule, which I think ends up clarifying it too. Thanks, Pedro Alves