From: Pedro Alves <palves@redhat.com>
To: Gary Benson <gbenson@redhat.com>, gdb-patches@sourceware.org
Cc: Doug Evans <xdje42@gmail.com>
Subject: Re: [PATCH 1/3] Remove spurious exceptions.h inclusions
Date: Tue, 07 Oct 2014 18:04:00 -0000 [thread overview]
Message-ID: <54342B41.3040607@redhat.com> (raw)
In-Reply-To: <1409586154-16196-2-git-send-email-gbenson@redhat.com>
On 09/01/2014 04:42 PM, Gary Benson wrote:
> --- a/gdb/f-valprint.c
> +++ b/gdb/f-valprint.c
> @@ -33,8 +33,6 @@
> #include "command.h"
> #include "block.h"
> #include "dictionary.h"
> -#include "exceptions.h"
> -
> extern void _initialize_f_valprint (void);
> static void info_common_command (char *, int);
Please leave the empty line.
> +++ b/gdb/valarith.c
> @@ -28,8 +28,6 @@
> #include "dfp.h"
> #include <math.h>
> #include "infcall.h"
> -#include "exceptions.h"
> -
> /* Define whether or not the C operator '/' truncates towards zero for
>
Ditto.
Otherwise OK.
Thanks,
Pedro Alves
next prev parent reply other threads:[~2014-10-07 18:04 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-09-01 15:42 [PATCH 0/3] Rationalize cleanups/exceptions includes Gary Benson
2014-09-01 15:42 ` [PATCH 3/3] Include common-exceptions.h in common-defs.h Gary Benson
2014-10-07 18:05 ` Pedro Alves
2014-09-01 15:42 ` [PATCH 1/3] Remove spurious exceptions.h inclusions Gary Benson
2014-10-07 18:04 ` Pedro Alves [this message]
2014-10-08 17:03 ` Doug Evans
2014-10-08 17:12 ` Doug Evans
2014-10-08 17:21 ` Pedro Alves
2014-10-08 17:24 ` Doug Evans
2014-10-09 9:43 ` Gary Benson
2014-10-09 11:43 ` Pedro Alves
2014-10-09 9:45 ` Gary Benson
2014-10-09 14:47 ` Doug Evans
2014-09-01 15:42 ` [PATCH 2/3] Include cleanups.h in common-defs.h Gary Benson
2014-10-07 18:05 ` Pedro Alves
2014-10-07 8:58 ` [PING PATCH 0/3] Rationalize cleanups/exceptions includes Gary Benson
2014-10-08 8:47 ` [PATCH " Gary Benson
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=54342B41.3040607@redhat.com \
--to=palves@redhat.com \
--cc=gbenson@redhat.com \
--cc=gdb-patches@sourceware.org \
--cc=xdje42@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox