From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <gdb-patches-return-116447-listarch-gdb-patches=sources.redhat.com@sourceware.org>
Received: (qmail 20045 invoked by alias); 7 Oct 2014 18:04:55 -0000
Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm
Precedence: bulk
List-Id: <gdb-patches.sourceware.org>
List-Subscribe: <mailto:gdb-patches-subscribe@sourceware.org>
List-Archive: <http://sourceware.org/ml/gdb-patches/>
List-Post: <mailto:gdb-patches@sourceware.org>
List-Help: <mailto:gdb-patches-help@sourceware.org>, <http://sourceware.org/ml/#faqs>
Sender: gdb-patches-owner@sourceware.org
Received: (qmail 20034 invoked by uid 89); 7 Oct 2014 18:04:54 -0000
Authentication-Results: sourceware.org; auth=none
X-Virus-Found: No
X-Spam-SWARE-Status: No, score=-2.0 required=5.0 tests=AWL,BAYES_00,SPF_HELO_PASS,SPF_PASS,T_RP_MATCHES_RCVD autolearn=ham version=3.3.2
X-HELO: mx1.redhat.com
Received: from mx1.redhat.com (HELO mx1.redhat.com) (209.132.183.28) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with (AES256-GCM-SHA384 encrypted) ESMTPS; Tue, 07 Oct 2014 18:04:54 +0000
Received: from int-mx11.intmail.prod.int.phx2.redhat.com (int-mx11.intmail.prod.int.phx2.redhat.com [10.5.11.24])	by mx1.redhat.com (8.14.4/8.14.4) with ESMTP id s97I4p5H002406	(version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-GCM-SHA384 bits=256 verify=FAIL);	Tue, 7 Oct 2014 14:04:51 -0400
Received: from [127.0.0.1] (ovpn01.gateway.prod.ext.ams2.redhat.com [10.39.146.11])	by int-mx11.intmail.prod.int.phx2.redhat.com (8.14.4/8.14.4) with ESMTP id s97I4njU027220;	Tue, 7 Oct 2014 14:04:50 -0400
Message-ID: <54342B41.3040607@redhat.com>
Date: Tue, 07 Oct 2014 18:04:00 -0000
From: Pedro Alves <palves@redhat.com>
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:31.0) Gecko/20100101 Thunderbird/31.1.1
MIME-Version: 1.0
To: Gary Benson <gbenson@redhat.com>, gdb-patches@sourceware.org
CC: Doug Evans <xdje42@gmail.com>
Subject: Re: [PATCH 1/3] Remove spurious exceptions.h inclusions
References: <1409586154-16196-1-git-send-email-gbenson@redhat.com> <1409586154-16196-2-git-send-email-gbenson@redhat.com>
In-Reply-To: <1409586154-16196-2-git-send-email-gbenson@redhat.com>
Content-Type: text/plain; charset=windows-1252
Content-Transfer-Encoding: 7bit
X-SW-Source: 2014-10/txt/msg00123.txt.bz2

On 09/01/2014 04:42 PM, Gary Benson wrote:
> --- a/gdb/f-valprint.c
> +++ b/gdb/f-valprint.c
> @@ -33,8 +33,6 @@
>  #include "command.h"
>  #include "block.h"
>  #include "dictionary.h"
> -#include "exceptions.h"
> -
>  extern void _initialize_f_valprint (void);
>  static void info_common_command (char *, int);

Please leave the empty line.

> +++ b/gdb/valarith.c
> @@ -28,8 +28,6 @@
>  #include "dfp.h"
>  #include <math.h>
>  #include "infcall.h"
> -#include "exceptions.h"
> -
>  /* Define whether or not the C operator '/' truncates towards zero for
>

Ditto.

Otherwise OK.

Thanks,
Pedro Alves