From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 12907 invoked by alias); 8 Oct 2014 17:03:16 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 12896 invoked by uid 89); 8 Oct 2014 17:03:15 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-3.0 required=5.0 tests=AWL,BAYES_00,RCVD_IN_DNSWL_LOW,SPF_PASS,T_RP_MATCHES_RCVD autolearn=ham version=3.3.2 X-HELO: mail-vc0-f180.google.com Received: from mail-vc0-f180.google.com (HELO mail-vc0-f180.google.com) (209.85.220.180) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with (AES128-SHA encrypted) ESMTPS; Wed, 08 Oct 2014 17:03:13 +0000 Received: by mail-vc0-f180.google.com with SMTP id le20so7111454vcb.39 for ; Wed, 08 Oct 2014 10:03:11 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:mime-version:in-reply-to:references:date :message-id:subject:from:to:cc:content-type; bh=WT8jHhm6b7itW1LXYMS5NcfvLbrhkw9foAhY7vjIOtg=; b=JB6m8czKRF857mcMc75Za1HleNmwtvZ2JMj6YVXj8CwlGY4osfYqbrcMsUy9EiJ4vM A/7rnMN8+kKuBfkxj6YTeHWui8T43qJVwr/irY7thEM+KQJfSc2XKlyhyU8lPoPSjQSz oLe9baX9/xJIddqZgSIWCnfhvb6rq6llQfZwfHGTnxDgzV8NHMq1DWUxCXgqru1G5Iu0 6daZjtsM/QPdjRpEB62AdEs2j3SDyiiDAS9U+CBP8q8Vvy/IgOHp/4bMii42aj3VM9kS 8qHU9bznZUMNYHRN6HlUZkK5bxq4RcLwCi9BDoMeFQuJxxUU3a/vCHdNdqbr+iqNKueR zO7w== X-Gm-Message-State: ALoCoQmeZc7+mDPjJhMAZLbxFTSGrGUp8tXlOH9R77EBacfBLAeb2PFuPzxgKRylkzxhzmHm4E5q MIME-Version: 1.0 X-Received: by 10.220.174.20 with SMTP id r20mr12017933vcz.11.1412787791224; Wed, 08 Oct 2014 10:03:11 -0700 (PDT) Received: by 10.52.181.65 with HTTP; Wed, 8 Oct 2014 10:03:11 -0700 (PDT) In-Reply-To: <1409586154-16196-2-git-send-email-gbenson@redhat.com> References: <1409586154-16196-1-git-send-email-gbenson@redhat.com> <1409586154-16196-2-git-send-email-gbenson@redhat.com> Date: Wed, 08 Oct 2014 17:03:00 -0000 Message-ID: Subject: Re: [PATCH 1/3] Remove spurious exceptions.h inclusions From: Doug Evans To: Gary Benson Cc: gdb-patches Content-Type: text/plain; charset=UTF-8 X-IsSubscribed: yes X-SW-Source: 2014-10/txt/msg00159.txt.bz2 On Mon, Sep 1, 2014 at 11:42 AM, Gary Benson wrote: > defs.h includes utils.h, and utils.h includes exceptions.h. All GDB > .c files include defs.h as their first line, so no file other than > utils.h needs to include exceptions.h. This commit removes all such > inclusions. > > Doug, I Cc'd you on this one as you asked me to avoid giant mechanical > ChangeLog entries but I couldn't figure out how I'd rewrite this one. For reference sake, I said that for two reasons: 1) to save you some typing 2) to keep the S/N ratio of the ChangeLog file from dropping, and in this case from dropping significantly. Yikes! > gdb/ChangeLog: > > * ada-lang.c: Do not include exceptions.h. > * ada-valprint.c: Likewise. > * amd64-tdep.c: Likewise. > [...] I realize one of the guidelines for changelogs is to document every file that's changed, but if we can agree that "All callers updated." can apply to all callers in all files, then I don't see why we couldn't be ok with something like the following for this case: * All .c files: Do not include exceptions.h. Yeah, it's not pedantically correct, not all .c files were touched. But I can live with that given the alternative.