From: Doug Evans <dje@google.com>
To: Eli Zaretskii <eliz@gnu.org>
Cc: Tom Tromey <tromey@redhat.com>,
Joel Brobecker <brobecker@adacore.com>,
Pedro Alves <palves@redhat.com>,
gdb-patches <gdb-patches@sourceware.org>
Subject: Re: [PATCH] Display configuration details in --help
Date: Wed, 10 Apr 2013 03:06:00 -0000 [thread overview]
Message-ID: <CADPb22QrNAtK_5uFRyyxvwi38ck-mQP++BqVO3CRSzT0B=GkRA@mail.gmail.com> (raw)
In-Reply-To: <83sj2za65y.fsf@gnu.org>
On Tue, Apr 9, 2013 at 11:51 AM, Eli Zaretskii <eliz@gnu.org> wrote:
>> >> > + fprintf_filtered (stream, _("\
>> >> > + --without-expat\n\
>> >> > +"));
>> >> > +#endif
>> >>
>> >> If we've already discussed this, please ignore, but ... :-)
>> >> I'd prefer one line per fprintf instead of three.
>> >
>> > Sorry, I'm not following: what 3 lines? Can you show how would you
>> > like the code be reformatted?
>>
>> fprintf_filtered (stream, _(" -with-expat\n")); // assuming 2
>> space indentation
>
> OK, I used the style I did because it makes it much easier to keep the
> alignment visible, without the need to count characters and columns.
I'm not sure. 13 is a lot to visualize and given the vertical span
it's not straightforward, to me anyway.
Using a more explicit form for the indentation (making it a parameter
to the printf) works better for me if the amount of indentation is
going to be that much.
next prev parent reply other threads:[~2013-04-09 19:31 UTC|newest]
Thread overview: 39+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-03-20 17:46 Eli Zaretskii
2013-03-21 18:00 ` Doug Evans
2013-03-21 18:25 ` Pedro Alves
2013-03-21 18:29 ` Joel Brobecker
2013-03-21 18:44 ` Eli Zaretskii
2013-03-21 19:11 ` Joel Brobecker
2013-03-21 20:39 ` Eli Zaretskii
2013-03-21 20:55 ` Joel Brobecker
2013-03-21 21:17 ` Tom Tromey
2013-03-21 22:23 ` Eli Zaretskii
2013-04-09 19:31 ` Eli Zaretskii
2013-04-09 19:46 ` Doug Evans
2013-04-09 20:04 ` Eli Zaretskii
2013-04-09 23:33 ` Doug Evans
2013-04-10 0:12 ` Pedro Alves
2013-04-10 0:48 ` Eli Zaretskii
2013-04-10 2:51 ` Doug Evans
2013-04-10 4:41 ` Eli Zaretskii
2013-04-11 2:41 ` Doug Evans
2013-04-11 1:20 ` Tom Tromey
2013-04-11 1:24 ` Pedro Alves
2013-04-11 2:43 ` Tom Tromey
2013-04-12 12:50 ` Eli Zaretskii
2013-04-12 14:43 ` Eli Zaretskii
2013-04-12 16:39 ` regroup --help text (was: Re: [PATCH] Display configuration details in --help) Pedro Alves
2013-06-22 11:31 ` regroup --help text " Eli Zaretskii
2013-06-25 19:30 ` Pedro Alves
2013-07-06 7:35 ` Eli Zaretskii
2013-04-12 20:50 ` [PATCH] Display configuration details in --help Tom Tromey
2013-04-14 14:17 ` Joel Brobecker
2013-04-16 1:34 ` Doug Evans
2013-04-16 9:46 ` regroup --help text Eli Zaretskii
2013-04-17 8:10 ` Doug Evans
2013-04-17 12:28 ` Eli Zaretskii
2013-04-14 14:16 ` [PATCH] Display configuration details in --help Doug Evans
2013-04-10 0:38 ` Eli Zaretskii
2013-04-10 3:06 ` Doug Evans [this message]
2013-04-10 4:44 ` Eli Zaretskii
2013-03-21 18:53 ` Eli Zaretskii
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CADPb22QrNAtK_5uFRyyxvwi38ck-mQP++BqVO3CRSzT0B=GkRA@mail.gmail.com' \
--to=dje@google.com \
--cc=brobecker@adacore.com \
--cc=eliz@gnu.org \
--cc=gdb-patches@sourceware.org \
--cc=palves@redhat.com \
--cc=tromey@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox