Re: [PATCH] Display configuration details in --help

[Eli Zaretskii <eliz@gnu.org>]

> Date: Tue, 9 Apr 2013 10:53:35 -0700
> From: Doug Evans <dje@google.com>
> Cc: Tom Tromey <tromey@redhat.com>, Joel Brobecker <brobecker@adacore.com>, 
> 	Pedro Alves <palves@redhat.com>, gdb-patches <gdb-patches@sourceware.org>
> >   GNU gdb (GDB) 7.5.1
> >   Copyright (C) 2012 Free Software Foundation, Inc.
> >   License GPLv3+: GNU GPL version 3 or later <http://gnu.org/licenses/gpl.html>
> >   This is free software: you are free to change and redistribute it.
> >   There is NO WARRANTY, to the extent permitted by law.  Type "show copying"
> >   and "show warranty" for details.                       ^^^^^^^^^^^^^^^^^^
> >   ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
> >
> > So I thought we should be consistent here, and offer the same for this
> > line:
> >
> >   This GDB was configured as "i686-pc-mingw32".
> >
> > I'm okay with not adding that, but can someone explain why it is
> > different from advertising "show copying" and "show warranty"?  Should
> > we remove those two as well?
> 
> I need to check, but I think(!) the "show copying" and "show warranty"
> are required by GNU standards.

As I said, I don't mind removing the line I added.  I'll do that if no
one else has a different opinion.

> >>  > +  fprintf_filtered (stream, _("\
> >>  > +             --without-expat\n\
> >>  > +"));
> >>  > +#endif
> >>
> >> If we've already discussed this, please ignore, but ... :-)
> >> I'd prefer one line per fprintf instead of three.
> >
> > Sorry, I'm not following: what 3 lines?  Can you show how would you
> > like the code be reformatted?
> 
>   fprintf_filtered (stream, _("  -with-expat\n"));  // assuming 2
> space indentation

OK, I used the style I did because it makes it much easier to keep the
alignment visible, without the need to count characters and columns.