From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 28148 invoked by alias); 9 Apr 2013 18:52:30 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 28130 invoked by uid 89); 9 Apr 2013 18:52:30 -0000 X-Spam-SWARE-Status: No, score=-4.3 required=5.0 tests=AWL,BAYES_00,KHOP_THREADED,RCVD_IN_DNSWL_NONE,RCVD_IN_HOSTKARMA_NO,SPF_SOFTFAIL autolearn=no version=3.3.1 Received: from mtaout22.012.net.il (HELO mtaout22.012.net.il) (80.179.55.172) by sourceware.org (qpsmtpd/0.84/v0.84-167-ge50287c) with ESMTP; Tue, 09 Apr 2013 18:52:25 +0000 Received: from conversion-daemon.a-mtaout22.012.net.il by a-mtaout22.012.net.il (HyperSendmail v2007.08) id <0ML0007004AH9Y00@a-mtaout22.012.net.il> for gdb-patches@sourceware.org; Tue, 09 Apr 2013 21:51:41 +0300 (IDT) Received: from HOME-C4E4A596F7 ([87.69.4.28]) by a-mtaout22.012.net.il (HyperSendmail v2007.08) with ESMTPA id <0ML00067M4E4TV90@a-mtaout22.012.net.il>; Tue, 09 Apr 2013 21:51:41 +0300 (IDT) Date: Wed, 10 Apr 2013 00:38:00 -0000 From: Eli Zaretskii Subject: Re: [PATCH] Display configuration details in --help In-reply-to: To: Doug Evans Cc: tromey@redhat.com, brobecker@adacore.com, palves@redhat.com, gdb-patches@sourceware.org Reply-to: Eli Zaretskii Message-id: <83sj2za65y.fsf@gnu.org> References: <83r4jaynqq.fsf@gnu.org> <514B4AC3.1090103@redhat.com> <83zjxwy4ux.fsf@gnu.org> <20130321191051.GF5447@adacore.com> <83r4j8y1kh.fsf@gnu.org> <20130321203919.GG5447@adacore.com> <87r4j8zd0k.fsf@fleche.redhat.com> <83ehf85u7x.fsf@gnu.org> <83wqsbadfe.fsf@gnu.org> <20836.17485.525118.795474@ruffy2.mtv.corp.google.com> <83txnfa9m7.fsf@gnu.org> X-SW-Source: 2013-04/txt/msg00253.txt.bz2 > Date: Tue, 9 Apr 2013 10:53:35 -0700 > From: Doug Evans > Cc: Tom Tromey , Joel Brobecker , > Pedro Alves , gdb-patches > > GNU gdb (GDB) 7.5.1 > > Copyright (C) 2012 Free Software Foundation, Inc. > > License GPLv3+: GNU GPL version 3 or later > > This is free software: you are free to change and redistribute it. > > There is NO WARRANTY, to the extent permitted by law. Type "show copying" > > and "show warranty" for details. ^^^^^^^^^^^^^^^^^^ > > ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ > > > > So I thought we should be consistent here, and offer the same for this > > line: > > > > This GDB was configured as "i686-pc-mingw32". > > > > I'm okay with not adding that, but can someone explain why it is > > different from advertising "show copying" and "show warranty"? Should > > we remove those two as well? > > I need to check, but I think(!) the "show copying" and "show warranty" > are required by GNU standards. As I said, I don't mind removing the line I added. I'll do that if no one else has a different opinion. > >> > + fprintf_filtered (stream, _("\ > >> > + --without-expat\n\ > >> > +")); > >> > +#endif > >> > >> If we've already discussed this, please ignore, but ... :-) > >> I'd prefer one line per fprintf instead of three. > > > > Sorry, I'm not following: what 3 lines? Can you show how would you > > like the code be reformatted? > > fprintf_filtered (stream, _(" -with-expat\n")); // assuming 2 > space indentation OK, I used the style I did because it makes it much easier to keep the alignment visible, without the need to count characters and columns.