From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 16280 invoked by alias); 9 Apr 2013 19:31:20 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 16270 invoked by uid 89); 9 Apr 2013 19:31:19 -0000 X-Spam-SWARE-Status: No, score=-6.3 required=5.0 tests=AWL,BAYES_00,KHOP_RCVD_TRUST,KHOP_THREADED,RCVD_IN_DNSWL_LOW,RCVD_IN_HOSTKARMA_YE,RP_MATCHES_RCVD autolearn=ham version=3.3.1 Received: from mail-wg0-f49.google.com (HELO mail-wg0-f49.google.com) (74.125.82.49) by sourceware.org (qpsmtpd/0.84/v0.84-167-ge50287c) with ESMTP; Tue, 09 Apr 2013 19:31:18 +0000 Received: by mail-wg0-f49.google.com with SMTP id e12so595792wgh.16 for ; Tue, 09 Apr 2013 12:31:16 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20120113; h=mime-version:x-received:in-reply-to:references:date:message-id :subject:from:to:cc:content-type:x-gm-message-state; bh=r54nR2gScOA1nTQSF8YZG6UpaEC+p/PX2qSCnWuAXs8=; b=j6bxzfyWlvURi4hvitDFN5iULPqd/E307HAjktirEbVhclXtNWVbir0BpgvBEvdzZb 0PopPAjCwDzHDZSZuRLrcQSDlRo/9rch5H3txjyD9zDiB7gWNdZ+13V4JdZHFzvuuj53 CoRH7AsQsQOWpztuB7HGOSLSUSrsSqrMlWCzdPYlXSbxhMROlcq0+PC9mg0O6xX9cFwJ Yc1TDkTAHykCk6CYPYXtxhDu/Dl+i3qjkvpJBD8mP5iGbfX1pWqh7PCB+b8f6lRqMl5C OZKlyuRqAbY31UJOOCLQL3DkAQ10kN3tM0CmW/Q8oIJt9ICYUD4MKmtPFs+9NJ33CEhl G7Dg== MIME-Version: 1.0 X-Received: by 10.180.94.39 with SMTP id cz7mr22101864wib.21.1365535876588; Tue, 09 Apr 2013 12:31:16 -0700 (PDT) Received: by 10.194.39.163 with HTTP; Tue, 9 Apr 2013 12:31:16 -0700 (PDT) In-Reply-To: <83sj2za65y.fsf@gnu.org> References: <83r4jaynqq.fsf@gnu.org> <514B4AC3.1090103@redhat.com> <83zjxwy4ux.fsf@gnu.org> <20130321191051.GF5447@adacore.com> <83r4j8y1kh.fsf@gnu.org> <20130321203919.GG5447@adacore.com> <87r4j8zd0k.fsf@fleche.redhat.com> <83ehf85u7x.fsf@gnu.org> <83wqsbadfe.fsf@gnu.org> <20836.17485.525118.795474@ruffy2.mtv.corp.google.com> <83txnfa9m7.fsf@gnu.org> <83sj2za65y.fsf@gnu.org> Date: Wed, 10 Apr 2013 03:06:00 -0000 Message-ID: Subject: Re: [PATCH] Display configuration details in --help From: Doug Evans To: Eli Zaretskii Cc: Tom Tromey , Joel Brobecker , Pedro Alves , gdb-patches Content-Type: text/plain; charset=ISO-8859-1 X-Gm-Message-State: ALoCoQnu0MgueC/GA2+EMkVwGbR8WMz+YjZ5wsymoBPVnaPqWVEQBpieX25991jYAnmcA4ZrEFdlHk35BOfi1X/cTExMTH7Xom8w2LRGXadNoZXl0t01fAGVkl3HJipN2d526pbXQsdyFesTiZAR2KKV9iLChhaoaPJ7mJYDBYxbtL0u8zcPn//v36UNIg9o5WN+Blbu21MgpFNhuylzuWNz1RRgMsMteQ== X-SW-Source: 2013-04/txt/msg00256.txt.bz2 On Tue, Apr 9, 2013 at 11:51 AM, Eli Zaretskii wrote: >> >> > + fprintf_filtered (stream, _("\ >> >> > + --without-expat\n\ >> >> > +")); >> >> > +#endif >> >> >> >> If we've already discussed this, please ignore, but ... :-) >> >> I'd prefer one line per fprintf instead of three. >> > >> > Sorry, I'm not following: what 3 lines? Can you show how would you >> > like the code be reformatted? >> >> fprintf_filtered (stream, _(" -with-expat\n")); // assuming 2 >> space indentation > > OK, I used the style I did because it makes it much easier to keep the > alignment visible, without the need to count characters and columns. I'm not sure. 13 is a lot to visualize and given the vertical span it's not straightforward, to me anyway. Using a more explicit form for the indentation (making it a parameter to the printf) works better for me if the amount of indentation is going to be that much.