Re: [PATCH]Add symbol whose field 'has_type' has been set to partial symbol table

[hex <heixia108@gmail.com>]

[-- Attachment #1: Type: text/plain, Size: 1040 bytes --]

> 2013/10/30 Tom Tromey <tromey@redhat.com>
>
> >>>>> ">" == hex  <heixia108@gmail.com> writes:
>
> >> Thank you for the review. I have attached the test case.
>
> The test case needs a ChangeLog entry.
>
> I'd much prefer a test using the DWARF assembler than one using actual
> assembly code.  There are other examples in gdb.dwarf2.  The reason to
> prefer the DWARF assembler is that it is more portable.
>
> >> # You should have received a copy of the GNU General Public License
> >> # along with this program.  If not, see <http://www.gnu.org/licenses/>.
> >> load_lib dwarf.exp
>
> A blank line between the comments and the first line of code, please.
>
> >> # Test DW_OP_stack_value and DW_OP_implicit_value.
>
> This comment seems incorrect.
>
> Tom

Thank you for the comments. A new version of test file is attached.
And the original patch is at
https://sourceware.org/ml/gdb-patches/2013-10/msg00747.html.

gdb/testsuite/Changelog:

2013-11-01  Jun Gong  <heixia108@gmail.com>

      * gdb.dwarf2/const-var.exp: New file.


Jun

[-- Attachment #2: const-var.exp --]
[-- Type: application/octet-stream, Size: 1749 bytes --]

# Copyright 2013 Free Software Foundation, Inc.

# This program is free software; you can redistribute it and/or modify
# it under the terms of the GNU General Public License as published by
# the Free Software Foundation; either version 3 of the License, or
# (at your option) any later version.
#
# This program is distributed in the hope that it will be useful,
# but WITHOUT ANY WARRANTY; without even the implied warranty of
# MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the
# GNU General Public License for more details.
#
# You should have received a copy of the GNU General Public License
# along with this program.  If not, see <http://www.gnu.org/licenses/>.

load_lib dwarf.exp

# This test can only be run on targets which support DWARF-2 and use gas.
if {![dwarf2_support]} {
    return 0
}

standard_testfile main.c .S

# Create the DWARF.
set asm_file [standard_output_file $srcfile2]
Dwarf::assemble $asm_file {
    declare_labels int_label

    cu {} {
	compile_unit {{language @DW_LANG_C}} {
	    int_label: base_type {
		{name int}
		{byte_size 4 sdata}
		{encoding @DW_ATE_signed}
	    }

	    DW_TAG_variable {
		{name const_var}
		{type :$int_label}
		{const_value 6 data1}
	    }
	}
    }
}

if  { [gdb_compile ${srcdir}/${subdir}/${srcfile} ${binfile}1.o \
	   object {nodebug}] != "" } {
    return -1
}

if  { [gdb_compile $asm_file ${binfile}2.o object {nodebug}] != "" } {
    return -1
}

if  { [gdb_compile [list ${binfile}1.o ${binfile}2.o] \
	   "${binfile}" executable {}] != "" } {
    return -1
}

clean_restart ${testfile}

if ![runto_main] {
    return -1
}

# Print const variable, test whether it has been added to partial
# symbol table.
gdb_test "print const_var" " = 6" "print const variable"