Mirror of the gdb-patches mailing list
 help / color / mirror / Atom feed
From: hex <heixia108@gmail.com>
To: gdb-patches@sourceware.org
Subject: [PATCH]Add symbol whose field 'has_type' has been set to partial symbol table
Date: Thu, 24 Oct 2013 06:59:00 -0000	[thread overview]
Message-ID: <CAB_AMN4CyoKKjd=_51d+a25HPnj=TK5aQTxGH321tkjtjOyg5Q@mail.gmail.com> (raw)

This patch intends to add symbol whose field 'has_type' has been set
to partial symbol table.

e.g.
// test.c
const int var = 3;

// Then compile it with `gcc -g -c test.c`(For the lastest GCC, we
need use 'gcc -g -O1 -c test.' to get the following DIE)
We could see the DIE of 'var' is as following:
 <1><25>: Abbrev Number: 2 (DW_TAG_variable)
    <26>   DW_AT_name        : var
    <2a>   DW_AT_decl_file   : 1
    <2b>   DW_AT_decl_line   : 1
    <2c>   DW_AT_type        : <0x31>
    <30>   DW_AT_const_value : 3

Latest GDB will not add it to partial symbol table because its symbol
satisfies 'pdi->d.locdesc == NULL'.  I think we need add it to partial
symbol table.


2013-10-24  Jun Gong  <heixia108@gmail.com>

          * dwarf2read.c(add_partial_symbol): Add symbol whose field
'has_type' has been set to partial symbol table.


--- gdb-7.6.50.20131021.orig/gdb/dwarf2read.c 2013-10-16
10:55:27.000000000 +0800
+++ gdb-7.6.50.20131021/gdb/dwarf2read.c 2013-10-24 14:29:18.737067814 +0800
@@ -6733,8 +6733,9 @@ add_partial_symbol (struct partial_die_i
  }
       else
  {
-  /* Static Variable.  Skip symbols without location descriptors.  */
-  if (pdi->d.locdesc == NULL)
+  /* Static Variable.  Skip symbols without location descriptors or
+     has_type not set.  */
+  if (pdi->d.locdesc == NULL && pdi->has_type == 0)
     {
       xfree (built_actual_name);
       return;


             reply	other threads:[~2013-10-24  6:59 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2013-10-24  6:59 hex [this message]
2013-10-24 20:31 ` Tom Tromey
2013-10-25  7:41   ` hex
2013-10-29 18:34     ` Tom Tromey
2013-11-01  6:29 hex
2013-11-07 15:41 ` Tom Tromey
2014-01-24  6:19 Jun Gong
2014-01-26  9:15 ` Yao Qi

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to='CAB_AMN4CyoKKjd=_51d+a25HPnj=TK5aQTxGH321tkjtjOyg5Q@mail.gmail.com' \
    --to=heixia108@gmail.com \
    --cc=gdb-patches@sourceware.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox